fix: litestar plugin session provider #332
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In contexts where the connection is not yet available in Litestar - i.e. guards - it's still possible to get a connection/session from the plugin's pool (which does exist in state). This adds handling to fall back to that pool, but requires both a synchronous and asynchronous approach depending on the plugin context.
sync/async contexts
ftsartek
force-pushed
the
fix/session-provider
branch
from
7476ad1 to
eef3112
Compare
ftsartek
changed the title
ftsartek
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Alters the handling for session/connection providers in the Litestar plugin so that as a fallback they can be captured from the pool rather than the already-created connection.
Because this involves instantiating from the pool, it requires a separate async and sync method depending on the context.
Closes
N/A