Skip to content

fix!: use descriptive prefixes for enum names that start with otherwise illegal identifiers #44

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
stainless-app merged 1 commit into from
Apr 2, 2025
Merged

fix!: use descriptive prefixes for enum names that start with otherwise illegal identifiers #44

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/lithic/models/card_convert_physical_params.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,7 +83,7 @@ class CardConvertPhysicalParams < Lithic::BaseModel
module ShippingMethod
extend Lithic::Enum

NUMBER_2_DAY = :"2-DAY"
SHIPPING_METHOD_2_DAY = :"2-DAY"
EXPEDITED = :EXPEDITED
EXPRESS = :EXPRESS
PRIORITY = :PRIORITY
Expand Down
2 changes: 1 addition & 1 deletion lib/lithic/models/card_create_params.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -335,7 +335,7 @@ module Type
module ShippingMethod
extend Lithic::Enum

NUMBER_2_DAY = :"2_DAY"
SHIPPING_METHOD_2_DAY = :"2_DAY"
EXPEDITED = :EXPEDITED
EXPRESS = :EXPRESS
PRIORITY = :PRIORITY
Expand Down
2 changes: 1 addition & 1 deletion lib/lithic/models/card_reissue_params.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,7 +87,7 @@ class CardReissueParams < Lithic::BaseModel
module ShippingMethod
extend Lithic::Enum

NUMBER_2_DAY = :"2-DAY"
SHIPPING_METHOD_2_DAY = :"2-DAY"
EXPEDITED = :EXPEDITED
EXPRESS = :EXPRESS
PRIORITY = :PRIORITY
Expand Down
2 changes: 1 addition & 1 deletion lib/lithic/models/card_renew_params.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -118,7 +118,7 @@ class CardRenewParams < Lithic::BaseModel
module ShippingMethod
extend Lithic::Enum

NUMBER_2_DAY = :"2-DAY"
SHIPPING_METHOD_2_DAY = :"2-DAY"
EXPEDITED = :EXPEDITED
EXPRESS = :EXPRESS
PRIORITY = :PRIORITY
Expand Down
2 changes: 1 addition & 1 deletion lib/lithic/models/transaction.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -556,7 +556,7 @@ module DecisionMadeBy
module LiabilityShift
extend Lithic::Enum

NUMBER_3DS_AUTHENTICATED = :"3DS_AUTHENTICATED"
LIABILITY_SHIFT_3DS_AUTHENTICATED = :"3DS_AUTHENTICATED"
ACQUIRER_EXEMPTION = :ACQUIRER_EXEMPTION
NONE = :NONE
TOKEN_AUTHENTICATED = :TOKEN_AUTHENTICATED
Expand Down
3 changes: 2 additions & 1 deletion rbi/lib/lithic/models/card_convert_physical_params.rbi
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -100,7 +100,8 @@ module Lithic
OrSymbol =
T.type_alias { T.any(Symbol, String, Lithic::Models::CardConvertPhysicalParams::ShippingMethod::TaggedSymbol) }

NUMBER_2_DAY = T.let(:"2-DAY", Lithic::Models::CardConvertPhysicalParams::ShippingMethod::TaggedSymbol)
SHIPPING_METHOD_2_DAY =
T.let(:"2-DAY", Lithic::Models::CardConvertPhysicalParams::ShippingMethod::TaggedSymbol)
EXPEDITED = T.let(:EXPEDITED, Lithic::Models::CardConvertPhysicalParams::ShippingMethod::TaggedSymbol)
EXPRESS = T.let(:EXPRESS, Lithic::Models::CardConvertPhysicalParams::ShippingMethod::TaggedSymbol)
PRIORITY = T.let(:PRIORITY, Lithic::Models::CardConvertPhysicalParams::ShippingMethod::TaggedSymbol)
Expand Down
2 changes: 1 addition & 1 deletion rbi/lib/lithic/models/card_create_params.rbi
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -315,7 +315,7 @@ module Lithic
OrSymbol =
T.type_alias { T.any(Symbol, String, Lithic::Models::CardCreateParams::ShippingMethod::TaggedSymbol) }

NUMBER_2_DAY = T.let(:"2_DAY", Lithic::Models::CardCreateParams::ShippingMethod::TaggedSymbol)
SHIPPING_METHOD_2_DAY = T.let(:"2_DAY", Lithic::Models::CardCreateParams::ShippingMethod::TaggedSymbol)
EXPEDITED = T.let(:EXPEDITED, Lithic::Models::CardCreateParams::ShippingMethod::TaggedSymbol)
EXPRESS = T.let(:EXPRESS, Lithic::Models::CardCreateParams::ShippingMethod::TaggedSymbol)
PRIORITY = T.let(:PRIORITY, Lithic::Models::CardCreateParams::ShippingMethod::TaggedSymbol)
Expand Down
2 changes: 1 addition & 1 deletion rbi/lib/lithic/models/card_reissue_params.rbi
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -100,7 +100,7 @@ module Lithic
OrSymbol =
T.type_alias { T.any(Symbol, String, Lithic::Models::CardReissueParams::ShippingMethod::TaggedSymbol) }

NUMBER_2_DAY = T.let(:"2-DAY", Lithic::Models::CardReissueParams::ShippingMethod::TaggedSymbol)
SHIPPING_METHOD_2_DAY = T.let(:"2-DAY", Lithic::Models::CardReissueParams::ShippingMethod::TaggedSymbol)
EXPEDITED = T.let(:EXPEDITED, Lithic::Models::CardReissueParams::ShippingMethod::TaggedSymbol)
EXPRESS = T.let(:EXPRESS, Lithic::Models::CardReissueParams::ShippingMethod::TaggedSymbol)
PRIORITY = T.let(:PRIORITY, Lithic::Models::CardReissueParams::ShippingMethod::TaggedSymbol)
Expand Down
2 changes: 1 addition & 1 deletion rbi/lib/lithic/models/card_renew_params.rbi
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -122,7 +122,7 @@ module Lithic
OrSymbol =
T.type_alias { T.any(Symbol, String, Lithic::Models::CardRenewParams::ShippingMethod::TaggedSymbol) }

NUMBER_2_DAY = T.let(:"2-DAY", Lithic::Models::CardRenewParams::ShippingMethod::TaggedSymbol)
SHIPPING_METHOD_2_DAY = T.let(:"2-DAY", Lithic::Models::CardRenewParams::ShippingMethod::TaggedSymbol)
EXPEDITED = T.let(:EXPEDITED, Lithic::Models::CardRenewParams::ShippingMethod::TaggedSymbol)
EXPRESS = T.let(:EXPRESS, Lithic::Models::CardRenewParams::ShippingMethod::TaggedSymbol)
PRIORITY = T.let(:PRIORITY, Lithic::Models::CardRenewParams::ShippingMethod::TaggedSymbol)
Expand Down
2 changes: 1 addition & 1 deletion rbi/lib/lithic/models/transaction.rbi
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -617,7 +617,7 @@ module Lithic
OrSymbol =
T.type_alias { T.any(Symbol, String, Lithic::Models::Transaction::CardholderAuthentication::LiabilityShift::TaggedSymbol) }

NUMBER_3DS_AUTHENTICATED =
LIABILITY_SHIFT_3DS_AUTHENTICATED =
T.let(
:"3DS_AUTHENTICATED",
Lithic::Models::Transaction::CardholderAuthentication::LiabilityShift::TaggedSymbol
Expand Down
2 changes: 1 addition & 1 deletion sig/lithic/models/card_convert_physical_params.rbs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@ module Lithic
module ShippingMethod
extend Lithic::Enum

NUMBER_2_DAY: :"2-DAY"
SHIPPING_METHOD_2_DAY: :"2-DAY"
EXPEDITED: :EXPEDITED
EXPRESS: :EXPRESS
PRIORITY: :PRIORITY
Expand Down
2 changes: 1 addition & 1 deletion sig/lithic/models/card_create_params.rbs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -155,7 +155,7 @@ module Lithic
module ShippingMethod
extend Lithic::Enum

NUMBER_2_DAY: :"2_DAY"
SHIPPING_METHOD_2_DAY: :"2_DAY"
EXPEDITED: :EXPEDITED
EXPRESS: :EXPRESS
PRIORITY: :PRIORITY
Expand Down
2 changes: 1 addition & 1 deletion sig/lithic/models/card_reissue_params.rbs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,7 @@ module Lithic
module ShippingMethod
extend Lithic::Enum

NUMBER_2_DAY: :"2-DAY"
SHIPPING_METHOD_2_DAY: :"2-DAY"
EXPEDITED: :EXPEDITED
EXPRESS: :EXPRESS
PRIORITY: :PRIORITY
Expand Down
2 changes: 1 addition & 1 deletion sig/lithic/models/card_renew_params.rbs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,7 @@ module Lithic
module ShippingMethod
extend Lithic::Enum

NUMBER_2_DAY: :"2-DAY"
SHIPPING_METHOD_2_DAY: :"2-DAY"
EXPEDITED: :EXPEDITED
EXPRESS: :EXPRESS
PRIORITY: :PRIORITY
Expand Down
2 changes: 1 addition & 1 deletion sig/lithic/models/transaction.rbs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -316,7 +316,7 @@ module Lithic
module LiabilityShift
extend Lithic::Enum

NUMBER_3DS_AUTHENTICATED: :"3DS_AUTHENTICATED"
LIABILITY_SHIFT_3DS_AUTHENTICATED: :"3DS_AUTHENTICATED"
ACQUIRER_EXEMPTION: :ACQUIRER_EXEMPTION
NONE: :NONE
TOKEN_AUTHENTICATED: :TOKEN_AUTHENTICATED
Expand Down