Rework Lime/Lyft revocation, add to admin#925
Merged
Conversation
This was an ambitious idea that could never be fully worked out since there are too many edge cases. Instead, we'll start with manual removal via admin, and can eventually automate it more predictably.
simplereg: support 'key' accessor support confirmation in admin actions
rgalanakis
force-pushed
the
lime-revoke-admin
branch
from
3cfa39a to
74ffd43
Compare
rgalanakis
force-pushed
the
lime-revoke-admin
branch
from
74ffd43 to
4f0d784
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #925 +/- ##
==========================================
+ Coverage 99.33% 99.82% +0.49%
==========================================
Files 752 748 -4
Lines 37132 37010 -122
==========================================
+ Hits 36884 36946 +62
+ Misses 248 64 -184 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
rgalanakis
force-pushed
the
lime-revoke-admin
branch
from
7d1577c to
02fc85d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The automated service revocation/removal on unenrollment didn't fit into paradigms since we have eligibility attributes (tests have been skipped and code not-operational). It is also a bit too risky to run automatically for now. We still have the scheduled revocation, and still in dry run mode.
Instead, hook lime/lyft revocation up to admin (using actions), so it can be done manually. This also required reworking how we handle Lime account closures, since we can't exchange a magic link in the backend anymore.