Skip to content

Replace SectionBuilder with function builders #6

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

Replace SectionBuilder with function builders #6

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
eb181b2
Increment iOS deployment target and Swift version
Jun 17, 2020
871172e
Update collection protocol conformances
Jun 17, 2020
75ba7a0
Move Section to its own file
Jun 17, 2020
df47ca7
Update tests to be more exhaustive
Jun 17, 2020
9cdae65
Add function builders to Section and Sections
Jun 24, 2020
ec2e808
Update to Swift 5.4
Feb 4, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Example/Podfile
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
platform :ios, '12.2'
platform :ios, '13.3'
use_frameworks!

target 'Sections_Tests' do
Expand Down
4 changes: 2 additions & 2 deletions Example/Podfile.lock
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,8 +9,8 @@ EXTERNAL SOURCES:
:path: "../"

SPEC CHECKSUMS:
Sections: d6bf60f4bb270e1e4da03f2f951633c9000951fa
Sections: 06192a63e3910601af0ff890fe088b12c5f1ec78

PODFILE CHECKSUM: 43476e85565543c48b2cf2871adfa90324d377b2
PODFILE CHECKSUM: aa797c4296c48695cdb0c2bcab3b3c71945d5d61

COCOAPODS: 1.9.0
6 changes: 3 additions & 3 deletions Example/Pods/Local Podspecs/Sections.podspec.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions Example/Pods/Manifest.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

400 changes: 204 additions & 196 deletions Example/Pods/Pods.xcodeproj/project.pbxproj
View file
Open in desktop

Large diffs are not rendered by default.

30 changes: 20 additions & 10 deletions Example/Sections.xcodeproj/project.pbxproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,8 +7,10 @@
objects = {

/* Begin PBXBuildFile section */
607FACEC1AFB9204008FA782 /* Tests.swift in Sources */ = {isa = PBXBuildFile; fileRef = 607FACEB1AFB9204008FA782 /* Tests.swift */; };
AFED56911D46FB490095C0C0 /* EquatableTests.swift in Sources */ = {isa = PBXBuildFile; fileRef = AFED56901D46FB490095C0C0 /* EquatableTests.swift */; };
BBB79A94249A7DC3005C84D6 /* SectionTests.swift in Sources */ = {isa = PBXBuildFile; fileRef = BBB79A93249A7DC3005C84D6 /* SectionTests.swift */; };
BBB79A96249A81B8005C84D6 /* SectionsTests.swift in Sources */ = {isa = PBXBuildFile; fileRef = BBB79A95249A81B8005C84D6 /* SectionsTests.swift */; };
BBB79A98249A959C005C84D6 /* SectionBuilderTests.swift in Sources */ = {isa = PBXBuildFile; fileRef = BBB79A97249A959C005C84D6 /* SectionBuilderTests.swift */; };
BBB79A9C249AA573005C84D6 /* RowBuilderTests.swift in Sources */ = {isa = PBXBuildFile; fileRef = BBB79A9B249AA573005C84D6 /* RowBuilderTests.swift */; };
D2C58D4D19007442E848C094 /* Pods_Sections_Tests.framework in Frameworks */ = {isa = PBXBuildFile; fileRef = B40AC96D941A8402BF02C807 /* Pods_Sections_Tests.framework */; };
/* End PBXBuildFile section */

Expand All @@ -17,10 +19,12 @@
5DEE35FF9DDB61C2A048C7E9 /* Sections.podspec */ = {isa = PBXFileReference; includeInIndex = 1; lastKnownFileType = text; name = Sections.podspec; path = ../Sections.podspec; sourceTree = "<group>"; };
607FACE51AFB9204008FA782 /* Sections_Tests.xctest */ = {isa = PBXFileReference; explicitFileType = wrapper.cfbundle; includeInIndex = 0; path = Sections_Tests.xctest; sourceTree = BUILT_PRODUCTS_DIR; };
607FACEA1AFB9204008FA782 /* Info.plist */ = {isa = PBXFileReference; lastKnownFileType = text.plist.xml; path = Info.plist; sourceTree = "<group>"; };
607FACEB1AFB9204008FA782 /* Tests.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = Tests.swift; sourceTree = "<group>"; };
7A51CAED75D45C1209C4DD07 /* README.md */ = {isa = PBXFileReference; includeInIndex = 1; lastKnownFileType = net.daringfireball.markdown; name = README.md; path = ../README.md; sourceTree = "<group>"; };
AFED56901D46FB490095C0C0 /* EquatableTests.swift */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.swift; path = EquatableTests.swift; sourceTree = "<group>"; };
B40AC96D941A8402BF02C807 /* Pods_Sections_Tests.framework */ = {isa = PBXFileReference; explicitFileType = wrapper.framework; includeInIndex = 0; path = Pods_Sections_Tests.framework; sourceTree = BUILT_PRODUCTS_DIR; };
BBB79A93249A7DC3005C84D6 /* SectionTests.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = SectionTests.swift; sourceTree = "<group>"; };
BBB79A95249A81B8005C84D6 /* SectionsTests.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = SectionsTests.swift; sourceTree = "<group>"; };
BBB79A97249A959C005C84D6 /* SectionBuilderTests.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = SectionBuilderTests.swift; sourceTree = "<group>"; };
BBB79A9B249AA573005C84D6 /* RowBuilderTests.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = RowBuilderTests.swift; sourceTree = "<group>"; };
D66F88A76A9976980026D75A /* Pods-Sections_Tests.release.xcconfig */ = {isa = PBXFileReference; includeInIndex = 1; lastKnownFileType = text.xcconfig; name = "Pods-Sections_Tests.release.xcconfig"; path = "Pods/Target Support Files/Pods-Sections_Tests/Pods-Sections_Tests.release.xcconfig"; sourceTree = "<group>"; };
F9DA03B35C36CEFBEE28B476 /* LICENSE */ = {isa = PBXFileReference; includeInIndex = 1; lastKnownFileType = text; name = LICENSE; path = ../LICENSE; sourceTree = "<group>"; };
/* End PBXFileReference section */
Expand Down Expand Up @@ -59,9 +63,11 @@
607FACE81AFB9204008FA782 /* Tests */ = {
isa = PBXGroup;
children = (
607FACEB1AFB9204008FA782 /* Tests.swift */,
BBB79A9B249AA573005C84D6 /* RowBuilderTests.swift */,
BBB79A97249A959C005C84D6 /* SectionBuilderTests.swift */,
BBB79A95249A81B8005C84D6 /* SectionsTests.swift */,
BBB79A93249A7DC3005C84D6 /* SectionTests.swift */,
607FACE91AFB9204008FA782 /* Supporting Files */,
AFED56901D46FB490095C0C0 /* EquatableTests.swift */,
);
path = Tests;
sourceTree = "<group>";
Expand Down Expand Up @@ -212,8 +218,10 @@
isa = PBXSourcesBuildPhase;
buildActionMask = 2147483647;
files = (
AFED56911D46FB490095C0C0 /* EquatableTests.swift in Sources */,
607FACEC1AFB9204008FA782 /* Tests.swift in Sources */,
BBB79A98249A959C005C84D6 /* SectionBuilderTests.swift in Sources */,
BBB79A96249A81B8005C84D6 /* SectionsTests.swift in Sources */,
BBB79A9C249AA573005C84D6 /* RowBuilderTests.swift in Sources */,
BBB79A94249A7DC3005C84D6 /* SectionTests.swift in Sources */,
);
runOnlyForDeploymentPostprocessing = 0;
};
Expand Down Expand Up @@ -267,11 +275,12 @@
GCC_WARN_UNINITIALIZED_AUTOS = YES_AGGRESSIVE;
GCC_WARN_UNUSED_FUNCTION = YES;
GCC_WARN_UNUSED_VARIABLE = YES;
IPHONEOS_DEPLOYMENT_TARGET = 12.2;
IPHONEOS_DEPLOYMENT_TARGET = 13.3;
MTL_ENABLE_DEBUG_INFO = YES;
ONLY_ACTIVE_ARCH = YES;
SDKROOT = iphoneos;
SWIFT_OPTIMIZATION_LEVEL = "-Onone";
SWIFT_VERSION = 5.0;
};
name = Debug;
};
Expand Down Expand Up @@ -315,10 +324,11 @@
GCC_WARN_UNINITIALIZED_AUTOS = YES_AGGRESSIVE;
GCC_WARN_UNUSED_FUNCTION = YES;
GCC_WARN_UNUSED_VARIABLE = YES;
IPHONEOS_DEPLOYMENT_TARGET = 12.2;
IPHONEOS_DEPLOYMENT_TARGET = 13.3;
MTL_ENABLE_DEBUG_INFO = NO;
SDKROOT = iphoneos;
SWIFT_COMPILATION_MODE = wholemodule;
SWIFT_VERSION = 5.0;
VALIDATE_PRODUCT = YES;
};
name = Release;
Expand Down
2 changes: 1 addition & 1 deletion Example/Sections.xcodeproj/xcshareddata/xcschemes/Sections-Example.xcscheme
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
<?xml version="1.0" encoding="UTF-8"?>
<Scheme
LastUpgradeVersion = "1130"
LastUpgradeVersion = "1150"
version = "1.3">
<BuildAction
parallelizeBuildables = "YES"
Expand Down
82 changes: 0 additions & 82 deletions Example/Tests/EquatableTests.swift
View file
Open in desktop

This file was deleted.

Loading