Skip to content

perf: update react and ripple#273

Merged
littensy merged 2 commits intomainfrom
perf/update-react-ripple
Sep 19, 2025
Merged

perf: update react and ripple#273
littensy merged 2 commits intomainfrom
perf/update-react-ripple

Conversation

@littensy
Copy link
Copy Markdown
Owner

No description provided.

@littensy littensy added game:app Relating to the React app dependencies Updates or adds dependencies type:perf Regarding performance and optimization labels Sep 19, 2025
@littensy littensy requested a review from Copilot September 19, 2025 20:24
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This pull request updates the animation system by migrating from the custom useMotion hook to the useSpring hook from @rbxts/react-ripple. The changes modernize the animation API and leverage the new reactive ripple library for better performance and consistency.

Key Changes

  • Removed custom useMotion hook in favor of useSpring from @rbxts/react-ripple
  • Updated animation API calls from .spring() to .setGoal() throughout the codebase
  • Updated package dependencies to use newer versions of React and Ripple libraries

Reviewed Changes

Copilot reviewed 32 out of 33 changed files in this pull request and generated 8 comments.

Show a summary per file
File Description
src/client/hooks/use-motion.ts Removed custom motion hook implementation
src/client/hooks/index.ts Updated exports to use react-ripple instead of local use-motion
src/client/constants/springs.ts Updated spring configuration to match new API
package.json Updated dependencies for React and Ripple libraries
Multiple component files Migrated from useMotion to useSpring with API updates
Files not reviewed (1)
  • pnpm-lock.yaml: Language not supported

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Comment thread src/client/components/ui/reactive-button/use-button-animation.ts
Comment thread src/client/components/ui/reactive-button/use-button-animation.ts
Comment thread src/client/components/ui/reactive-button/reactive-button.tsx
Comment thread src/client/components/world/snakes/snakes.tsx
Comment thread src/client/components/menu/support/support-product.tsx
Comment thread src/client/components/menu/support/support-heart.tsx
Comment thread src/client/components/menu/support/support-heart.tsx
Comment thread src/client/components/menu/navigation/indicator.tsx
@littensy littensy merged commit 5ba1cb4 into main Sep 19, 2025
1 check passed
@littensy littensy deleted the perf/update-react-ripple branch September 19, 2025 20:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Updates or adds dependencies game:app Relating to the React app type:perf Regarding performance and optimization

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants