Conversation
There was a problem hiding this comment.
Pull Request Overview
This pull request updates the animation system by migrating from the custom useMotion hook to the useSpring hook from @rbxts/react-ripple. The changes modernize the animation API and leverage the new reactive ripple library for better performance and consistency.
Key Changes
- Removed custom
useMotionhook in favor ofuseSpringfrom@rbxts/react-ripple - Updated animation API calls from
.spring()to.setGoal()throughout the codebase - Updated package dependencies to use newer versions of React and Ripple libraries
Reviewed Changes
Copilot reviewed 32 out of 33 changed files in this pull request and generated 8 comments.
Show a summary per file
| File | Description |
|---|---|
| src/client/hooks/use-motion.ts | Removed custom motion hook implementation |
| src/client/hooks/index.ts | Updated exports to use react-ripple instead of local use-motion |
| src/client/constants/springs.ts | Updated spring configuration to match new API |
| package.json | Updated dependencies for React and Ripple libraries |
| Multiple component files | Migrated from useMotion to useSpring with API updates |
Files not reviewed (1)
- pnpm-lock.yaml: Language not supported
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.