fix: prevent duplicate control response for already-handled requests (#229)

[Nathan Schram (nathanschram)]

Summary

• Fix control request expiry sending duplicate DENY for requests already approved via Telegram callback
• Add reconciliation loop in translate() that syncs _HANDLED_REQUESTS with state.pending_control_requests
• Emit action_completed to clear stale inline keyboards from progress messages

Fixes #229

What happened

When a user clicks Approve on a control request (e.g. ExitPlanMode), send_claude_control_response() writes the response to Claude Code's stdin and marks it in _HANDLED_REQUESTS. But it can't access state.pending_control_requests (local to the translate loop). After 5 minutes, the expiry check finds the already-handled request and sends a second DENY — Claude Code receives conflicting approve+deny responses for the same request_id and stalls.

The upstream Claude Code freeze (ignoring a valid approval written to stdin) is tracked in anthropics/claude-code#39666.

Changes

src/untether/runners/claude.py:

• Add request_to_action mapping on ClaudeStreamState (request_id → action_id)
• Reconciliation loop before expiry check: removes handled requests from pending, emits action_completed
• Guard on expiry list comprehension: rid not in _HANDLED_REQUESTS

tests/test_claude_control.py:

• test_handled_request_not_auto_denied_on_expiry — verifies handled requests skip auto-deny
• test_reconciliation_emits_action_completed_for_stale_keyboard — verifies keyboard cleanup

Test plan

• All 1817 tests pass (81.39% coverage)
• Lint clean (ruff check)
• Dev service starts cleanly
• Integration test: send task in plan mode via @untether_dev_bot, approve ExitPlanMode, verify no stale keyboard and no expired_auto_deny in logs

🤖 Generated with Claude Code

[coderabbitai]

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: a8a8c877-f232-45f7-b7c3-26de48d8611c

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• 🔍 Trigger review

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch fix/control-request-expiry-duplicate-229

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}