fix: /new command dispatch for all modes, not just topics (#236)#242
Merged
Nathan Schram (nathanschram) merged 1 commit intodevfrom Mar 29, 2026
Merged
Conversation
`/new` was only handled in `_dispatch_builtin_command()` when `topics.enabled=true`. With topics disabled (assistant mode), the command fell through to prompt dispatch and triggered an engine run. - Move `/new` out of the `topics.enabled` gate, mirroring `/ctx` pattern: topic → `handle_new_command`, chat session → `handle_chat_new_command`, stateless → cancel + reply - Add `chat_session_store` and `chat_session_key` to `TelegramCommandContext` dataclass - Remove unreachable early routing for `/new` at lines 1871-1910 (now handled by `_dispatch_builtin_command`) Verified: all 6 engine forum topic chats return "no stored sessions" instead of triggering runs. Project supergroup chats unaffected. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
/newwas only handled in_dispatch_builtin_command()whentopics.enabled=true. With topics disabled (assistant mode), the command fell through to prompt dispatch and triggered an engine run instead of clearing sessions./newout of thetopics.enabledgate, mirroring the/ctxpattern (handles topic, chat session, and stateless modes)chat_session_storeandchat_session_keytoTelegramCommandContext/new(40 lines)Test plan
/newin all 6 forum topic engine chats → "no stored sessions" (not engine run)/newin project supergroup chat → "🧹 cleared stored sessions" (unchanged)Fixes #236
🤖 Generated with Claude Code