Merged
Conversation
TBD: video and audio tracks not making it to onboard_ui for unknown reasons
see issue 17 in portalbot
🤦 aiortc. yeah. really starting to dislike.
Owner
Author
|
The error occurring above was why basic_bot had been fixed at version 1.10.1 of aiortc. See also aiortc/aiortc#1406 I'm going to work on a workaround for the CI issue, I'm not sure if I invoke aiortc in the tests, so maybe installing aiortc pip is not necessary. |
No sure if it will override or not, may need full copy of base requirements. hope not, but....
… version so we need a base requirements and then CI and ....
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See the following issues:
littlebee/portalbot#17
aiortc/aiortc#1258