Merged
Conversation
Tested on pi5 Bookworm (64bit). The service test is unfortunately not able to run on mac, but I was able to run all of our tests on a pi5 includng the vision service tests. The stats on camera capture using the bookworm->picamera2->tflight are looking really great - 28fps on capture and 26fps on recognition. 🍾
littlebee
commented
Feb 8, 2025
| return [] | ||
|
|
||
| detector = TFLiteDetectMock() # type: ignore | ||
| detector = TFLiteDetect() |
Owner
Author
There was a problem hiding this comment.
I decided to let fail here and catch it elsewhere
littlebee
commented
Feb 8, 2025
not sure how the bb_create e2e was working without node installed? That is what it looks like from the test failure. The test_create e2e test is failing to find node_modules because the webapp was able to be built
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In order to support users with Pi4 or Pi5 + Bookworm + ribbon camera cable, I added optional support for using Picamera2. opencsv capture doesn't currently work in this configuration.
You should be able to grok how to use the module from the doc updates in this PR.