Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1438 +/- ##
=======================================
Coverage 99.89% 99.89%
=======================================
Files 6 6
Lines 955 955
Branches 128 128
=======================================
Hits 954 954
Partials 1 1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
There was a problem hiding this comment.
Pull request overview
This PR tightens test validation around the thermostat circuit (HC2) behavior by asserting the exact _request() call arguments, making the test verify the correct API payload rather than only that a call occurred.
Changes:
- Updated
test_thermostat_circuit2_no_temp_rangeto assert_requestis awaited withbase_path="/JS"and the expected{Parameter, Value, Type}payload.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



This pull request makes a targeted improvement to the test coverage for the thermostat circuit functionality. Specifically, it enhances the assertion in
test_thermostat_circuit2_no_temp_rangeto verify that the_requestmethod is called with the correct parameters, ensuring more precise validation of the code's behavior.Test coverage improvements:
tests/test_circuit.py: Updated the assertion intest_thermostat_circuit2_no_temp_rangeto check thatmock_bsblan_circuit._requestis called with the expected arguments (base_path="/JS"and the correct data payload), rather than just being awaited.