Skip to content

fix: update codeql-action to v4.35.2 and add SCORECARD_TOKEN#1445

Merged
liudger merged 1 commit intomainfrom
fix/scorecard-imposter-commit
Apr 16, 2026
Merged

fix: update codeql-action to v4.35.2 and add SCORECARD_TOKEN#1445
liudger merged 1 commit intomainfrom
fix/scorecard-imposter-commit

Conversation

@liudger
Copy link
Copy Markdown
Owner

@liudger liudger commented Apr 16, 2026

The pinned SHA for github/codeql-action was flagged as an 'imposter commit' by the scorecard webapp, causing publish_results to fail with: 'imposter commit: 0e9f55954318745b37b7933c693bc093f7336125 does not belong to github/codeql-action/upload-sarif'

Updated to v4.35.2 (95e58e9a) which is a valid release commit. Also added repo_token input using SCORECARD_TOKEN secret for the Branch-Protection check.

The pinned SHA for github/codeql-action was flagged as an 'imposter
commit' by the scorecard webapp, causing publish_results to fail with:
'imposter commit: 0e9f55954318745b37b7933c693bc093f7336125 does not
belong to github/codeql-action/upload-sarif'

Updated to v4.35.2 (95e58e9a) which is a valid release commit.
Also added repo_token input using SCORECARD_TOKEN secret for the
Branch-Protection check.
Copilot AI review requested due to automatic review settings April 16, 2026 10:41
@liudger liudger added bugfix Inconsistencies or issues which will cause a problem for users or implementers. ci Work that improves the continue integration. labels Apr 16, 2026
@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 16, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 99.89%. Comparing base (070312f) to head (12c6782).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1445   +/-   ##
=======================================
  Coverage   99.89%   99.89%           
=======================================
  Files           6        6           
  Lines         955      955           
  Branches      128      128           
=======================================
  Hits          954      954           
  Partials        1        1           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@sonarqubecloud
Copy link
Copy Markdown

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates pinned github/codeql-action SHAs used in the repository’s security workflows and adds a dedicated token input to the Scorecard workflow to support the Branch-Protection check.

Changes:

  • Bump github/codeql-action/* from the previously pinned SHA to v4.35.2 (pinned by commit SHA).
  • Add repo_token input to ossf/scorecard-action using secrets.SCORECARD_TOKEN.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File Description
.github/workflows/scorecard.yml Adds repo_token for Scorecard and updates CodeQL SARIF upload action pin.
.github/workflows/codeql.yaml Updates CodeQL init/analyze action pins to v4.35.2.

with:
results_file: results.sarif
results_format: sarif
repo_token: ${{ secrets.SCORECARD_TOKEN }}
Copy link

Copilot AI Apr 16, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

repo_token is always set to secrets.SCORECARD_TOKEN. If that secret is not configured, this expression resolves to an empty string and can override the action’s default token, causing authentication failures. Consider falling back to github.token (or conditionally setting repo_token) so the workflow still runs when the secret is absent, and/or document the required secret in the workflow comments.

Suggested change
repo_token: ${{ secrets.SCORECARD_TOKEN }}
# Prefer a dedicated Scorecard token when configured, but fall back
# to the default GitHub token so the workflow still runs if the
# secret is not set.
repo_token: ${{ secrets.SCORECARD_TOKEN || github.token }}

Copilot uses AI. Check for mistakes.
@liudger liudger merged commit 881f3a5 into main Apr 16, 2026
22 checks passed
@liudger liudger deleted the fix/scorecard-imposter-commit branch April 16, 2026 10:54
@github-actions github-actions Bot locked and limited conversation to collaborators Apr 18, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

bugfix Inconsistencies or issues which will cause a problem for users or implementers. ci Work that improves the continue integration.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants