Skip to content

Update CONTRIBUTING.md with development setup and coding standards#1447

Merged
liudger merged 5 commits intomainfrom
docs/update-contributing
Apr 16, 2026
Merged

Update CONTRIBUTING.md with development setup and coding standards#1447
liudger merged 5 commits intomainfrom
docs/update-contributing

Conversation

@liudger
Copy link
Copy Markdown
Owner

@liudger liudger commented Apr 16, 2026

  • Add development setup instructions with uv
  • Add coding standards section (Python 3.12+, Ruff, MyPy, Pylint)
  • Add testing requirements (95%+ coverage, 100% patch coverage)
  • Expand pull request process with clear steps
  • Link to code of conduct

@liudger liudger added the documentation Solely about the documentation of the project. label Apr 16, 2026
Copilot AI review requested due to automatic review settings April 16, 2026 11:17
Copy link
Copy Markdown
Owner Author

@liudger liudger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looking good

@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 16, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 99.89%. Comparing base (1d0d66e) to head (4a157a5).
⚠️ Report is 5 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1447   +/-   ##
=======================================
  Coverage   99.89%   99.89%           
=======================================
  Files           6        6           
  Lines         955      955           
  Branches      128      128           
=======================================
  Hits          954      954           
  Partials        1        1           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the repository contribution guidelines to document the expected local development workflow and contribution standards for the python-bsblan async Python client.

Changes:

  • Add development setup instructions using uv.
  • Document coding standards (Python 3.12+, Ruff/formatting, typing, linting) and how to run checks via prek.
  • Add testing/coverage expectations and expand the pull request process steps, including a Code of Conduct link.

Comment thread .github/CONTRIBUTING.md Outdated
Comment thread .github/CONTRIBUTING.md
Comment thread .github/CONTRIBUTING.md Outdated
Comment thread .github/CONTRIBUTING.md Outdated
liudger added 4 commits April 16, 2026 14:03
- Add development setup instructions with uv
- Add coding standards section (Python 3.12+, Ruff, MyPy, Pylint)
- Add testing requirements (95%+ coverage, 100% patch coverage)
- Expand pull request process with clear steps
- Link to code of conduct
The project uses ty for type checking (in pre-commit and CI), not MyPy.
Updated CONTRIBUTING.md and copilot-instructions.md to match.
Added site/ to .gitignore (mkdocs build output).

# Conflicts:
#	.gitignore
The prettier pre-commit hook requires Node.js and npm packages.
Updated CONTRIBUTING.md with prerequisites and pointed to make setup.
Added npm ci to the Makefile setup target.
fail_under is set to 53 and CI doesn't enforce a coverage threshold.
Reworded to describe 95%/100% as project targets tracked via Codecov.
@liudger liudger force-pushed the docs/update-contributing branch from eaf4b0c to d957829 Compare April 16, 2026 12:03
@sonarqubecloud
Copy link
Copy Markdown

@liudger liudger merged commit 3f21ac2 into main Apr 16, 2026
16 checks passed
@liudger liudger deleted the docs/update-contributing branch April 16, 2026 12:56
@github-actions github-actions Bot locked and limited conversation to collaborators Apr 18, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

documentation Solely about the documentation of the project.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants