-
Notifications
You must be signed in to change notification settings - Fork 2
Refactor validation of parameters on bsblan device API calls #995
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ing sections during initialization
…tups for sensor and hot water state
…evice states and hot water information
…re flexible class design
…type of get_section_params method
…ity and efficiency
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
enhancement
Enhancement of the code, not introducing new features.
hacktoberfest
Issues/PRs are participating in the Hacktoberfest.
hacktoberfest-accepted
Issues/PRs are participating in the Hacktoberfest.
major
This PR causes a major version bump in the version number.
new-feature
New features or options.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.


Changed the way attributes/parameters are validated. This way we can check if features exist on heating system.
We adde validator class to check the parameters and update the api config accordingly