Skip to content

Conversation

@liudger
Copy link
Owner

@liudger liudger commented Oct 29, 2024

Changed the way attributes/parameters are validated. This way we can check if features exist on heating system.
We adde validator class to check the parameters and update the api config accordingly

@liudger liudger added enhancement Enhancement of the code, not introducing new features. minor This PR causes a minor version bump in the version number. labels Oct 29, 2024
@liudger liudger self-assigned this Oct 29, 2024
@liudger liudger added hacktoberfest-accepted Issues/PRs are participating in the Hacktoberfest. hacktoberfest Issues/PRs are participating in the Hacktoberfest. major This PR causes a major version bump in the version number. new-feature New features or options. and removed minor This PR causes a minor version bump in the version number. labels Oct 31, 2024
@liudger liudger changed the title Refactor constants and model attributes for legionella functionality Refactor validation of parameters on bsblan device API calls Oct 31, 2024
@sonarqubecloud
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
62.3% Coverage on New Code (required ≥ 80%)

See analysis details on SonarCloud

@liudger liudger merged commit 3d83399 into main Oct 31, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Nov 2, 2024
@liudger liudger deleted the add-extra-parameters-dhw branch November 27, 2024 12:29
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

enhancement Enhancement of the code, not introducing new features. hacktoberfest Issues/PRs are participating in the Hacktoberfest. hacktoberfest-accepted Issues/PRs are participating in the Hacktoberfest. major This PR causes a major version bump in the version number. new-feature New features or options.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants