Skip to content

Doctrine collections compatibility#188

Merged
DonCallisto merged 2 commits intoliuggio:masterfrom
mnocon:doctrine-collections-compatibility
Mar 7, 2023
Merged

Doctrine collections compatibility#188
DonCallisto merged 2 commits intoliuggio:masterfrom
mnocon:doctrine-collections-compatibility

Conversation

@mnocon
Copy link
Copy Markdown
Contributor

@mnocon mnocon commented Mar 7, 2023

Follow-up to the discussion in #187

I've decided to use https://github.com/symfony/deprecation-contracts , because it provides a unified way to do deprecations. Also it's already a transitive dependency of this package:

symfony/config               v6.2.7     requires symfony/deprecation-contracts (^2.1|^3) 
symfony/console              v6.2.7     requires symfony/deprecation-contracts (^2.1|^3) 
symfony/dependency-injection v6.2.7     requires symfony/deprecation-contracts (^2.1|^3) 

@mnocon mnocon marked this pull request as ready for review March 7, 2023 10:57
@DonCallisto
Copy link
Copy Markdown
Collaborator

DonCallisto commented Mar 7, 2023

LGTM thanks

@DonCallisto DonCallisto merged commit 52b7768 into liuggio:master Mar 7, 2023
@mnocon
Copy link
Copy Markdown
Contributor Author

mnocon commented Mar 7, 2023

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants