Skip to content

Add playground force-destroy option#846

Merged
hatemhosny merged 3 commits intolive-codes:developfrom
felixhuttmann:add-playground-destroy-force-option
Jun 8, 2025
Merged

Add playground force-destroy option#846
hatemhosny merged 3 commits intolive-codes:developfrom
felixhuttmann:add-playground-destroy-force-option

Conversation

@felixhuttmann
Copy link
Copy Markdown
Contributor

What type of PR is this? (check all applicable)

  • ✨ Feature

Description

Add a { force: true } option on playground.destroy to permit destroying playground instances even when the iframe is stuck in an endless loop.

Related Tickets & Documents

Fixes #845

Added tests?

  • 👍 yes
  • 🙅 no, because they aren't needed
  • 🙋 no, because I need help

Added to documentations?

  • 📓 docs (./docs)
  • 📕 storybook (./storybook)
  • 📜 README.md
  • 🙅 no documentation needed

@netlify
Copy link
Copy Markdown

netlify Bot commented Jun 6, 2025

Deploy Preview for livecodes ready!

Name Link
🔨 Latest commit 59b2412
🔍 Latest deploy log https://app.netlify.com/projects/livecodes/deploys/68456d9fb02a61000826c58c
😎 Deploy Preview https://deploy-preview-846--livecodes.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@felixhuttmann felixhuttmann force-pushed the add-playground-destroy-force-option branch from 05f8720 to faac6e8 Compare June 6, 2025 16:42
@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud Bot commented Jun 8, 2025

@hatemhosny
Copy link
Copy Markdown
Collaborator

Thank you @felixhuttmann

Your approach is reasonable enough to be used as the default behaviour (without having to pass any arguments).
I have added that.

This should be available in the next SDK release. I will let you know when it is released.
Thank you.

@hatemhosny hatemhosny merged commit fe19282 into live-codes:develop Jun 8, 2025
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants