Merged
Conversation
✅ Deploy Preview for livecodes ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Contributor
|
Size Change: +575 B (+0.06%) Total Size: 1.02 MB
ℹ️ View Unchanged
|
WalkthroughAdds view-transition-aware theme switching: Changes
Sequence Diagram(s)mermaid Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes 🚥 Pre-merge checks | ✅ 4✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches
🧪 Generate unit tests (beta)
No actionable comments were generated in the recent review. 🎉 🧹 Recent nitpick comments
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Fix all issues with AI agents
In `@src/livecodes/core.ts`:
- Around line 1984-1992: The error comes from using document.startViewTransition
which isn't in TS DOM types; update runViewTransition to use a safe type
assertion or add a declaration so TS knows about startViewTransition. Either:
add a global interface Document declaration that defines startViewTransition?:
(cb: () => void | Promise<void>) => unknown in a .d.ts file, or change the check
in runViewTransition to cast document as any or as unknown as {
startViewTransition?: Function } before accessing startViewTransition, keeping
the existing logic in runViewTransition(fn: () => void | Promise<void>).
🧹 Nitpick comments (1)
src/livecodes/core.ts (1)
4066-4083:transitionThemeruns on every editor settings change, even when theme hasn't changed.
changeEditorSettingshandles changes like font family, editor type, etc. The view transition animation will fire even when only non-theme settings change, which adds unnecessary visual flicker. Consider guarding:♻️ Suggested guard
setUserConfig(newConfig); const updatedConfig = getConfig(); - transitionTheme(updatedConfig.theme, updatedConfig.editorTheme); + if (newConfig.theme != null || newConfig.editorTheme != null) { + transitionTheme(updatedConfig.theme, updatedConfig.editorTheme); + } else { + setTheme(updatedConfig.theme, updatedConfig.editorTheme); + }
Deploying livecodes with
|
| Latest commit: |
cb1ca63
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://f4f9a69e.livecodes.pages.dev |
| Branch Preview URL: | https://theme-transition.livecodes.pages.dev |
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
use transition animation when changing theme
Summary by CodeRabbit
New Features
Style
Chores