Conversation
jonatanklosko
commented
Apr 4, 2026
Comment on lines
+553
to
+558
| defp params_to_columns(params) when is_list(params) do | ||
| Enum.map(params, fn | ||
| %Adbc.Column{} = col -> col | ||
| param -> Adbc.Column.new([param]) | ||
| end) | ||
| end |
Member
Author
There was a problem hiding this comment.
We had separate branches for when a parameter is a column or one of many primitives. By building a column here, it is all unified downstream.
Contributor
There was a problem hiding this comment.
Ah, this is great. It may mean we don't handle all primitives yet, but that can be implemented for new in the future, so that's fine!
Contributor
|
💚 💙 💜 💛 ❤️ Merging cause I want to push a tiny optimization to |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Notable changes:
%Column{},%Field{},%BufferData{}.nanoarrow::UniqueSchema,nanoarrow::UniqueArrayfor RAII memory management, which makes it easier to avoid memory leaks.%Adbc.Column{}with both:fieldand:datain a single pass. Recently we switched materialization, so that it doesn't build individual terms in the NIF, but instead we return simple structs like%BufferData{}with resource binary inside. This means that the more expensive part is not materialization, but decoding later as part ofto_list.