Fix saving notebook to S3 file system#3134
Merged
hugobarauna merged 2 commits intomainfrom Feb 18, 2026
Merged
Conversation
Derive the Inspect protocol on Livebook.FileSystem.S3 excluding access_key_id and secret_access_key, so they are never leaked in error logs or terminal output.
Add the missing update/2 clause for {:mount_file_system, file_system}
in PersistenceComponent. Without it, switching to an S3 file system
in the persistence dialog crashes with a KeyError.
josevalim
approved these changes
Feb 18, 2026
jonatanklosko
pushed a commit
that referenced
this pull request
Feb 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reported by a Livebook Teams customer.
mount_file_systemevent handler)access_key_id,secret_access_key) from log output