Refactor to merge LiveCode Script and iRev #13
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
September 19, 2015 08:18
This commit adds support for source.lcb to be linted using lc-compile. It adds two new settings: * The path for lc-compile * The module paths delimited by ; Default settings assume a debug build of the livened repo in the home directory.
The linter now detects server scripts by looking for the opening tag in the script. This change enables us to use the same set of generated autocomplete snippets without duplicating them. It also makes maintenance easier by reducing grammar duplication.
Member
Author
|
Er... hold the phone on this as it breaks other grammars. I just checked php. I'll see what I can come up with but I have a lot on right now so perhaps target this at 0.7 release so it doesn't hold things up. |
This commit reinstates iRev as a grammar. iRev now includes the LiveCode Script grammar for reuse.
Member
Author
|
Hmm... whitespace diffs. Atom strips all the trailing whitespace from files you touch sorry. I'll investigate the merge conflict |
Member
Author
|
Sorry, it was a whitespace issue on a spot where I've been testing the linter. Should merge cleanly now. |
Contributor
|
This looks good, thanks. |
peter-b
added a commit
that referenced
this pull request
Sep 23, 2015
Refactor to merge LiveCode Script and iRev
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The linter now detects server scripts by looking for the opening tag
in the script. This change enables us to use the same set of generated
autocomplete snippets without duplicating them. It also makes
maintenance easier by reducing grammar duplication.