Skip to content
This repository was archived by the owner on Aug 31, 2021. It is now read-only.

[[ Bug 19856 ]] Don't subscribe to ideExtensionLog from card and stack#1629

Merged
livecodeali merged 2 commits intodevelop-8.1from
bugfix-19856
Jun 13, 2017
Merged

[[ Bug 19856 ]] Don't subscribe to ideExtensionLog from card and stack#1629
livecodeali merged 2 commits intodevelop-8.1from
bugfix-19856

Conversation

@livecodeali
Copy link
Copy Markdown
Member

@livecodeali livecodeali commented Jun 13, 2017 •
edited
Loading

Remove re-subscription to ideExtensionLog when selecting a new extension from the dropdown menu - this was causing subscription by the stack in addition to previous subscription by the card.

@livecodeali livecodeali added this to the 8.1.6-rc-1 milestone Jun 13, 2017
@livecodeali
Copy link
Copy Markdown
Member Author

livecodeali commented Jun 13, 2017

Removed:

revIDEUnsubscribeAll
revIDESubscribe "ideExtensionLog"

from script of openExtension handler

@livecodeali
Copy link
Copy Markdown
Member Author

livecodeali commented Jun 13, 2017

Also added to script of stack:

on closeStack
   revIDEUnsubscribeAll
end closeStack

@runrevmark
Copy link
Copy Markdown
Contributor

runrevmark commented Jun 13, 2017

@livecode-vulcan review ok b7f181e

@livecode-vulcan
Copy link
Copy Markdown

livecode-vulcan commented Jun 13, 2017

💙 review by @runrevmark ok b7f181e

@livecodeali livecodeali merged commit 7e50e45 into develop-8.1 Jun 13, 2017
@livecodeali livecodeali deleted the bugfix-19856 branch June 13, 2017 14:16
@livecodeali livecodeali mentioned this pull request Jun 13, 2017
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

No one assigned

Labels

bug vulcan/reviewed

Projects

None yet

Milestone

8.1.6-rc-1

Development

Successfully merging this pull request may close these issues.

3 participants

@livecodeali @runrevmark @livecode-vulcan