This repository was archived by the owner on Aug 31, 2021. It is now read-only.
[[ Bug 19890 ]] Remove the possibility of bringing up palettes for incorrect objects#1637
Merged
montegoulding merged 2 commits intodevelop-8.1from Jun 30, 2017
Merged
Conversation
If an object waiting for a palette to open becomes deselected, go back to the selection step. Also, ensure this works for stacks by implementing similar code in ideActiveStacksChanged to ideSelectedObjectChanged
…t steps This is required for the enforcement of correct selection to work. Also, ensure all select steps highlight the object in question.
Contributor
|
@livecode-vulcan review ok b1b9394 @livecodeali this looks fine but I can't help wondering if we should just have something like this that you can add to any step. |
|
💙 review by @montegoulding ok b1b9394 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ensure object is always selected when step requires
If an object waiting for a palette to open becomes deselected, go
back to the selection step.
Also, ensure this works for stacks by implementing similar code in
ideActiveStacksChanged to ideSelectedObjectChanged
Ensure all palette for obj steps are preceded by select steps
This is required for the enforcement of correct selection to work.
Also, ensure all select steps highlight the object in question.