Skip to content
This repository was archived by the owner on Aug 31, 2021. It is now read-only.

[Bug 20330] Do not allow stack names to contain quotes#1719

Merged
montegoulding merged 3 commits intodevelop-8.1from
bugfix-20330
Sep 7, 2017
Merged

[Bug 20330] Do not allow stack names to contain quotes#1719
montegoulding merged 3 commits intodevelop-8.1from
bugfix-20330

Conversation

@livecodepanos
Copy link
Copy Markdown
Contributor

No description provided.

@montegoulding
Copy link
Copy Markdown
Contributor

@livecode-vulcan review ok 92f6976

@livecodepanos I wonder if this should be at engine level for any object name. Also comma would be a good thing to check for.

@livecode-vulcan
Copy link
Copy Markdown

💙 review by @montegoulding ok 92f6976

@montegoulding
Copy link
Copy Markdown
Contributor

@livecodepanos actually comma is handled at engine level with:

MCStringFindAndReplaceChar(*t_new_string, ',', '_', kMCCompareExact);

... perhaps there should be a general sanitize_object_name that ensures chars that we really don't want in names are cleaned out

@montegoulding montegoulding merged commit 3d13347 into develop-8.1 Sep 7, 2017
@livecodeali livecodeali deleted the bugfix-20330 branch March 20, 2018 11:15
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants