This repository was archived by the owner on Aug 31, 2021. It is now read-only.
[[ ExtensionStandaloneSettings ]] Add mechanism for extensions standalone settings#1838
Merged
livecodeali merged 6 commits intodevelopfrom Dec 13, 2017
Merged
Conversation
This commit cleans up the extension metadata handling so that - metadata standaloneSettings.'setting name'.'meta prop' is handled and converted into the same property info style as property metadata - cleans up some manifest parsing
…s list This patch adds a settings icon to the inclusions pane of the standalone settings when there are per-extension standalone settings available. Clicking on this pops up a modeless 'inspector' for any properties declared in standaloneSettings metadata in the extension.
Contributor
|
Hmm... We really need to make search for inclusions a button you click every now and then to update this list |
Member
Author
|
How does that relate to this? (I agree, just wondering if you've noticed an aspect of it that this exacerbates) |
Contributor
|
Just that you won't see the cog unless you are not searching for inclusions |
Member
Author
|
ah, yes, good point |
Contributor
|
That probably doesn't need to cause this to be WIP though. We just need a small change I think. Make search for inclusions boolean with checkbox and make it add to existing inclusions rather than clobber them then make it save inclusions after the search so they appear in the list next time. Perhaps adding a search now button would also be good. |
Contributor
|
@livecode-vulcan review ok ae3c945 |
|
💙 review by @montegoulding ok ae3c945 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This patch adds several features to enabled extensions to specify standalone settings in their metadata. These appear as cogs in the inclusions list, which then pop up a property inspector-style sheet of properties that can be set.
