[[ DataGrid 2 ]] Edit mode and swipe actions. by livecodemichael · Pull Request #1861 · livecode/livecode-ide

livecodemichael · 2017-12-15T13:17:42Z

The DataGrid has been extended to include a new edit mode and swipe actions.

The following properties have been added to the DataGrid:

set the dgEditMode of group "dg" to <true|false>
set the dgProps["animate actions"] of group "dg" to <true|false>
set the dgProps["enable swipe"] of group "dg" to <true|false>
set the dgProps["edit mode action control"] of group "dg" to <control id>
set the dgProps["edit mode action select control"] of group "dg" to <control id>
set the dgProps["edit mode reorder control"] of group "dg" to <control id>
set the dgProps["left swipe control"] of group "dg" to <control id>
set the dgProps["right swipe control"] of group "dg" to <control id>

The following commands have been added to the DataGrid:

dispatch "EditModeShowActionControlForIndex" to group "dg" with <index>
dispatch "EditModeShowActionControlForIndex" to group "dg" with <true|false>
dispatch "RowSwipeShowControlForIndexAndSide" to group "dg" with <index>, <left|right>
dispatch "RowSwipeHideControl" to group "dg" with <true|false>

The following messages are sent to the DataGrid:

on EditModeReorderStarted pIndex, pLineNo
on EditModeReorderCompleted pIndex, pStartLineNo, pNewLineNo

The following messages are sent to the appropriate row control of the DataGrid:

on EditModeActionSelectControlClicked pTarget
on EditModeActionControlClicked pTarget
on EditModeActionControlHidden
on RowSwipedRight
on RowSwipedLeft
on RowLeftSwipeControlClicked pTarget
on RowRightSwipeControlClicked pTarget
on RowLeftSwipeControlHidden
on RowRightSwipeControlHidden

The LayoutControl message sent to the row control has been updated to add a second parameter:

on LayoutControl pControlRect, pWorkingRect

The following messages are sent to the each row control of the DataGrid, allowing for control customisation:

on GetEditModeActionControl
on GetEditModeActionSelectControl
on GetEditModeReorderControl
on GetLeftSwipeControl
on GetRightSwipeControl

revdatagridlibrary.rev has been updated to include the new behaviours and an updated template row behaviour script.

livecodeali · 2017-12-18T10:13:19Z

+Associations: datagrid, datagrid commands
+
+Syntax: dispatch "RowSwipeShowControlForIndexAndSide" to group "DataGrid" with
+<row index>, {left | right}


I think "left" and "right" should be in quotes here

livecodeali · 2017-12-18T10:15:00Z

+<EditModeActionSelectControlClicked> if you wish to perform a custom behavior.
+
+pTarget is the target of the click. Use this to determine where in the action
+control the user clicked.


You can put the info about pTarget in a

Parameters: pTarget:

section

livecodeali · 2017-12-18T10:15:53Z

+<EditModeActionControlClicked> if you wish to perform a custom behavior.
+
+pTarget is the target of the click. Use this to determine where in the action
+control the user clicked.


And again here

livecodeali · 2017-12-18T10:18:07Z

+
+<pIndex> is the index of the reordered row. <pStartLineNo> is the original line
+sequence number of the row within the data grid. <pNewLineNo> is the new line
+sequence number of the row within the data grid.


These should be documented as parameters

livecodeali · 2017-12-18T10:27:24Z

+local sReorderStartIndex
+local sReorderStartLine
+local sReorderLastHoverLine
+local sReoderMouseMoveInProgress


Not a bug as you've been consistent, but there's a typo in this variable name

Haha, reoder. I'm an idiot.

livecodeali · 2017-12-18T10:27:49Z

+local sReorderScrollPollMsgID
+
+constant kReorderScrollPollRate = 30
+constant kReoderScrollPollMargin = 30


Another reoder here

livecodeali · 2017-12-18T10:28:51Z

+local sCustomisableControlsInitialised
+local sCustomisableControlsA
+local sConstomisableControlsSingletonsA
+local sConstomisableControlsSingletonCopyMapA


Some constomisable rather than customisables here

It's not even close. Where did the n come from?

Haha, looks like your fingers got so used to typing constant. I do it all the type with local when I'm trying to lock messages- locak messages all the time

livecodeali · 2017-12-18T10:39:07Z

This looks great as far as I can tell, other than a couple of docs things and non-critical typos. One minor suggestion I have is that the Get...Control messages be functions rather than on - I see you are constructing the dispatch message generically, but am I right in thinking the ones that are expected to return something are done separately (in which case there's no reason not to use dispatch function)?

livecodemichael · 2017-12-18T11:12:35Z

@livecodeali Yeah, I wasn't sure about that. I originally had them as functions since they return a result - it makes sense. But then figured there wasn't really any context elsewhere for doing something similar: The programmer implementing a function that's called by LiveCode felt a bit weird. Handling messages sent by LiveCode felt more typical.

I don't think either method is particularly nice, so I'm happy to go either way. As you say, it's just a single word change (along with docs updates). I don't know if anyone else has an opinion.

The DataGrid has been extended to include a new edit mode and swipe actions. The following properties have been added to the DataGrid: - set the dgEditMode of group "dg" to <true|false> - set the dgProps["animate actions"] of group "dg" to <true|false> - set the dgProps["enable swipe"] of group "dg" to <true|false> - set the dgProps["edit mode action control"] of group "dg" to <control id> - set the dgProps["edit mode action select control"] of group "dg" to <control id> - set the dgProps["edit mode reorder control"] of group "dg" to <control id> - set the dgProps["left swipe control"] of group "dg" to <control id> - set the dgProps["right swipe control"] of group "dg" to <control id> The following commands have been added to the DataGrid: - dispatch "EditModeShowActionControlForIndex" to group "dg" with <index> - dispatch "EditModeShowActionControlForIndex" to group "dg" with <true|false> - dispatch "RowSwipeShowControlForIndexAndSide" to group "dg" with <index>, <left|right> - dispatch "RowSwipeHideControl" to group "dg" with <true|false> The following messages are sent to the DataGrid: - on EditModeReorderStarted pIndex, pLineNo - on EditModeReorderCompleted pIndex, pStartLineNo, pNewLineNo The following messages are sent to the appropriate row control of the DataGrid: - on EditModeActionSelectControlClicked pTarget - on EditModeActionControlClicked pTarget - on EditModeActionControlHidden - on RowSwipedRight - on RowSwipedLeft - on RowLeftSwipeControlClicked pTarget - on RowRightSwipeControlClicked pTarget - on RowLeftSwipeControlHidden - on RowRightSwipeControlHidden The following messages are sent to the each row control of the DataGrid, allowing for control customisation: - on GetEditModeActionControl - on GetEditModeActionSelectControl - on GetEditModeReorderControl - on GetLeftSwipeControl - on GetRightSwipeControl revdatagridlibrary.rev has been updated to include the new behaviours and an updated template row behaviour script.

livecodeali · 2017-12-18T11:25:31Z

@livecodemichael The precedent in my head is NumberOfRows and CacheKeyForRow in the data view, but then again that's not out there for general use! Ok, let's leave it as on then :-)

livecodeali · 2017-12-18T13:42:47Z

@livecode-vulcan review ok 8089bd6

livecode-vulcan · 2017-12-18T13:45:21Z

💙 review by @livecodeali ok 8089bd6

livecodemichael added pr/need-release-notes pr/need-docs and removed pr/need-release-notes labels Dec 15, 2017

livecodepanos added this to the 9.0.0-dp-11 milestone Dec 15, 2017

livecodemichael force-pushed the feature-datagrid2_edit_swipe branch 2 times, most recently from 5c24500 to 655d400 Compare December 15, 2017 17:07

livecodemichael removed the pr/need-docs label Dec 15, 2017

livecodemichael force-pushed the feature-datagrid2_edit_swipe branch 2 times, most recently from 4b651ad to 37b6f03 Compare December 18, 2017 10:00

livecodeali reviewed Dec 18, 2017

View reviewed changes

livecodemichael force-pushed the feature-datagrid2_edit_swipe branch from 37b6f03 to 404b67a Compare December 18, 2017 11:14

livecodemichael force-pushed the feature-datagrid2_edit_swipe branch from 404b67a to 8089bd6 Compare December 18, 2017 11:22

livecode-vulcan added the vulcan/reviewed label Dec 18, 2017

livecodeali merged commit 1734126 into livecode:develop Dec 18, 2017

Conversation

livecodemichael commented Dec 15, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

livecodeali commented Dec 18, 2017

Uh oh!

livecodemichael commented Dec 18, 2017

Uh oh!

livecodeali commented Dec 18, 2017

Uh oh!

livecodeali commented Dec 18, 2017

Uh oh!

livecode-vulcan commented Dec 18, 2017

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

livecodemichael commented Dec 15, 2017 •

edited

Loading