This repository was archived by the owner on Aug 31, 2021. It is now read-only.
[[ DataGrid 2]] Assorted bug fixes.#1875
Merged
livecodepanos merged 1 commit intolivecode:developfrom Dec 20, 2017
Merged
Conversation
Manually send reorder move. This effectively throttles the mouse move message (which was interfering with animations in certain situations) and also means that we allow widgets to be used as reorder controls (since widgets don't pass mouse move by default). Make sure to set the horozontal position of the reorder control in the LayoutControl handler. This ensures the reorder control is in the correct pisition after scrolls and resizes. Extend the reorder scroll check to beyond the rect of the data grid. This means users can drag above or below the group and the scroll will continue. Make sure we send the animation pulse message at the correct intervals. Use the correct animation properties for animating the reoder control. Correctly check the bounds on reordering, preventing reodering line numbers not in the datagrid.
Contributor
|
@livecode-vulcan review ok 3cb73a5 |
|
💙 review by @livecodepanos ok 3cb73a5 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Manually send reorder move. This effectively throttles the mouse move
message (which was interfering with animations in certain situations)
and also means that we allow widgets to be used as reorder controls
(since widgets don't pass mouse move by default).
Make sure to set the horozontal position of the reorder control in the
LayoutControl handler. This ensures the reorder control is in the
correct position after scrolls and resizes.
Extend the reorder scroll check to beyond the rect of the data grid.
This means users can drag above or below the group and the scroll will
continue.
Make sure we send the animation pulse message at the correct intervals.
Use the correct animation properties for animating the reoder control.
Correctly check the bounds on reordering, preventing reodering line
numbers not in the datagrid.