This repository was archived by the owner on Aug 31, 2021. It is now read-only.
[[ Bug 20857 ]] Fix widget property ordering in inspector#1905
Merged
livecodepanos merged 3 commits intodevelopfrom Mar 5, 2018
Merged
[[ Bug 20857 ]] Fix widget property ordering in inspector#1905livecodepanos merged 3 commits intodevelopfrom
livecodepanos merged 3 commits intodevelopfrom
Conversation
Iterate over the widget's properties giving them all an order reflecting their position in the manifest. Additionally, don't iterate through all property names when merging in IDE property info.
| # there was no property node in the XML | ||
| union tPropertyDataA[tProperty] with tDataA[tProperty] | ||
|
|
||
| # Now take any default roperty info that was not specified |
|
|
||
| # Now take any default roperty info that was not specified | ||
| # in the manifest | ||
| union tPropertyDataA[tProperty] with tIDEPropInfoA |
Contributor
There was a problem hiding this comment.
Don't we have this data already from here https://github.com/livecode/livecode-ide/pull/1905/files#diff-5a54288a32499468dd2cab9f178bed1dR643
Member
Author
There was a problem hiding this comment.
No - these are ones for which metadata exists but no property declaration - i.e. overrides. However, we can be a bit more efficient by skipping the ones already processed
Contributor
|
@livecode-vulcan review ok f818100 |
|
💙 review by @montegoulding ok f818100 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Iterate over the widget's properties giving them all an order
reflecting their position in the manifest. Additionally, don't
iterate through all property names when merging in IDE property
info.