This repository was archived by the owner on Aug 31, 2021. It is now read-only.
libcairo: Build fixes for revpdfprinter on iOS 10 and MacOS#61
Merged
peter-b merged 3 commits intodevelop-8.1from Sep 22, 2016
Merged
libcairo: Build fixes for revpdfprinter on iOS 10 and MacOS#61peter-b merged 3 commits intodevelop-8.1from
peter-b merged 3 commits intodevelop-8.1from
Conversation
Make sure that all source files are included in libcairo's "sources" list, but exclude the ones that cause problems from the build.
Consistently use `ATSUFontID` everywhere in the Quartz support code. This patch should be submitted upstream.
When building Cairo to run on iOS 10, the ApplicationServices framework and `ATSUFontID` type are not available. However, the majority of the Quartz support code works just fine because it relies purely on the CoreGraphics and CoreText frameworks. This patch adds three feature macros: - `CAIRO_QUARTZ_HAS_CORE_GRAPHICS` - define to 1 to indicate availability of the CoreGraphics framework. It should be defined on both iOS and MacOS - `CAIRO_QUARTZ_HAS_APPLICATION_SERVICES` - define to 1 to indicate availability of the ApplicationSercives framework. It should be defined only on MacOS - `CAIRO_QUARTZ_HAS_ATSUFONTID` - define to 1 if the `ATSUFontID` type is defined by the ApplicationServices header files. It should normally be defined on MacOS This patch should be submitted upstream (possibly with some Autoconf magic).
Contributor
|
@livecode-vulcan review okay e9a9b71 |
|
💙 review by @livecodefraser ok e9a9b71 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When building Cairo to run on iOS 10, the ApplicationServices framework and
ATSUFontIDtype are not available. However, the majority of the Quartz support code works just fine because it relies purely on the CoreGraphics and CoreText frameworks.This pull request adds three feature macros:
CAIRO_QUARTZ_HAS_CORE_GRAPHICS- define to 1 to indicate availability of the CoreGraphics framework. It should be defined on both iOS and MacOSCAIRO_QUARTZ_HAS_APPLICATION_SERVICES- define to 1 to indicate availability of the ApplicationServices framework. It should be defined only on MacOSCAIRO_QUARTZ_HAS_ATSUFONTID- define to 1 if theATSUFontIDtype is defined by the ApplicationServices header files. It should normally be defined on MacOS