This repository was archived by the owner on Aug 31, 2021. It is now read-only.
libpq: Use macosx platform strlcpy() implementation#90
Merged
peter-b merged 1 commit intolivecode:developfrom Dec 16, 2016
Merged
libpq: Use macosx platform strlcpy() implementation#90peter-b merged 1 commit intolivecode:developfrom
peter-b merged 1 commit intolivecode:developfrom
Conversation
When compiling with libc++, it isn't necessary for libpq to provide its own implementation of `strlcpy()`. In fact, attempting to build `strlcpy.h` fails because libc++ defines `strlcpy` to be a macro.
Contributor
|
@livecode-vulcan review okay f90b0b3 |
|
💙 review by @livecodefraser ok f90b0b3 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When compiling with libc++, it isn't necessary for libpq to provide
its own implementation of
strlcpy(). In fact, attempting tobuild
strlcpy.hfails because libc++ definesstrlcpyto be amacro.