This repository was archived by the owner on Aug 31, 2021. It is now read-only.
Bugfix extension build scripts#6309
Merged
livecodeali merged 19 commits intolivecode:developfrom Mar 5, 2018
Merged
Conversation
7b71dfb to
72b69ca
Compare
b07dbf9 to
bc99136
Compare
Also plumb in script library to build scripts, and replace a bunch of shell script with LiveCode.
bc99136 to
3dc4b57
Compare
In particular, move the packaging code from revIDEDeveloperExtensionLibrary, so that we specify exactly what files are put in the package rather than recursively zipping the extension folder
0a47f91 to
174e057
Compare
Member
Author
|
I think since all these functions are used during build / running IDE, they will be well-tested for now. |
There's not really an ideal place for something like a server script that provides access to an extension, so move it to resources folder for now.
Member
Author
|
Check branch: #6365 |
|
|
||
| Summary: This library provides handlers for managing livecode extension packages | ||
|
|
||
| Version: 1.0.0 |
Contributor
There was a problem hiding this comment.
@livecodeali do we have a flag we can add here to indicate this is an IDE library?
Member
Author
There was a problem hiding this comment.
Not yet I don't think...
| end __dependencyOrder | ||
|
|
||
| private function __extensionIsBuiltin pID | ||
| switch pID |
Contributor
There was a problem hiding this comment.
@livecodeali this seems like something we might want to add an enhancement request for a function
Contributor
|
@livecode-vulcan review ok 2a37058 |
Contributor
|
💙 review by @montegoulding ok 2a37058 |
livecode-vulcan
added a commit
that referenced
this pull request
Mar 4, 2018
…_scripts Bugfix extension build scripts This patch will get extension packages building on Windows again
Contributor
|
😎 test success 2a37058
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This patch will get extension packages building on Windows again