Skip to content
This repository was archived by the owner on Aug 31, 2021. It is now read-only.

Bugfix extension build scripts#6309

Merged
livecodeali merged 19 commits intolivecode:developfrom
livecodeali:bugfix-extension_build_scripts
Mar 5, 2018
Merged

Bugfix extension build scripts#6309
livecodeali merged 19 commits intolivecode:developfrom
livecodeali:bugfix-extension_build_scripts

Conversation

@livecodeali
Copy link
Copy Markdown
Member

This patch will get extension packages building on Windows again

@livecodeali livecodeali added this to the 9.0.0-rc-1 milestone Jan 31, 2018
@livecodeali livecodeali force-pushed the bugfix-extension_build_scripts branch 5 times, most recently from 7b71dfb to 72b69ca Compare February 5, 2018 20:49
@livecodeali livecodeali force-pushed the bugfix-extension_build_scripts branch 2 times, most recently from b07dbf9 to bc99136 Compare March 1, 2018 12:43
In particular, move the packaging code from
revIDEDeveloperExtensionLibrary, so that we specify exactly what files
are put in the package rather than recursively zipping the extension
folder
@livecodeali livecodeali force-pushed the bugfix-extension_build_scripts branch from 0a47f91 to 174e057 Compare March 1, 2018 15:49
@livecodeali
Copy link
Copy Markdown
Member Author

I think since all these functions are used during build / running IDE, they will be well-tested for now.

There's not really an ideal place for something like a server
script that provides access to an extension, so move it to resources
folder for now.
@livecodeali
Copy link
Copy Markdown
Member Author

Check branch: #6365


Summary: This library provides handlers for managing livecode extension packages

Version: 1.0.0
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@livecodeali do we have a flag we can add here to indicate this is an IDE library?

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not yet I don't think...

end __dependencyOrder

private function __extensionIsBuiltin pID
switch pID
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@livecodeali this seems like something we might want to add an enhancement request for a function

@montegoulding
Copy link
Copy Markdown
Contributor

@livecode-vulcan review ok 2a37058

@livecode-vulcan
Copy link
Copy Markdown
Contributor

💙 review by @montegoulding ok 2a37058

livecode-vulcan added a commit that referenced this pull request Mar 4, 2018
…_scripts

Bugfix extension build scripts

This patch will get extension packages building on Windows again
@livecode-vulcan
Copy link
Copy Markdown
Contributor

😎 test success 2a37058

  • try-community-armv6-android-api8: success
  • try-community-armv6-android-api9: success
  • try-community-js-emscripten-sdk1.35: success
  • try-community-universal-ios-iphoneos11.2: success
  • try-community-universal-ios-iphonesimulator11.2: success
  • try-community-universal-mac-macosx10.6: success
  • try-community-universal-mac-macosx10.9: success
  • try-community-x86-linux-debian7: success
  • try-community-x86-linux-debian8: success
  • try-community-x86_64-linux-debian7: success
  • try-community-x86_64-linux-debian8: success
  • try-community-x86-win32: success
  • try-community-x86_64-win32: success

@livecodeali livecodeali merged commit b8d7174 into livecode:develop Mar 5, 2018
@livecodeali livecodeali deleted the bugfix-extension_build_scripts branch March 5, 2018 10:32
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants