Fix camera permission requesting when initially opening the app #273
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
lukasIO
approved these changes
Sep 4, 2025
abdul-0-muheed
pushed a commit
to abdul-0-muheed/sdc-joint-frontend
that referenced
this pull request
Oct 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, in some context, the camera permissions would be immediately requested when opening the starter app. This isn't ideal, especially since the camera starts disabled and a user may choose to never use it.
Instead, now prompt for permissions when clicking the "disable camera" button for the first time.
Also, adding this behavior uncovered that if a user didn't initially load the page with camera permissions granted, the camera source list would be empty. To fix this, use the pattern from here - when opening the select menu, refetch all devices in the list.
