fix: handle missing room configuration in token route#326
Closed
fahim-uddin wants to merge 1 commit intolivekit-examples:mainfrom
Closed
fix: handle missing room configuration in token route#326fahim-uddin wants to merge 1 commit intolivekit-examples:mainfrom
fahim-uddin wants to merge 1 commit intolivekit-examples:mainfrom
Conversation
|
@fahim-uddin is attempting to deploy a commit to the LiveKit Team on Vercel. A member of the Team first needs to authorize it. |
thomasyuill-livekit
approved these changes
Apr 11, 2026
Contributor
thomasyuill-livekit
left a comment
thomasyuill-livekit
left a comment
There was a problem hiding this comment.
Thank you for catching this.
Seems we were only testing with explicit agent dispatch and didn't realize this broke with automatic agent dispatch
Contributor
|
I can't merge your PR because it's failing the linter I've opened a new PR with your changed here and added you as a co-author thank you for your help! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue: #325