-
Notifications
You must be signed in to change notification settings - Fork 23
Redesign #20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Redesign #20
Conversation
|
@hiroshihorie I saw your crash on TF, looks like nullptr unfortunately, somewhere in (unsymbolicated) LiveKitWebRTC We can try reproducing that (device change?) |
hiroshihorie
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice 🔥
@pblazej it doesn't crash now, I wonder if it was some kind of perms error, did you change something related to audio ?
bcherry
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this looks great. i don't think any of the items you mentioned are necessarily blockers to merge. i want to help improve the readmes soon
I just used |
.regularsize classAppViewModel- mostlyRoomstate, connection, devicesChatViewModel- encapsulating the chat sub-featureMessageSenderprotocol to handle local text messagesTODOs
fastlane match? or build for vision instead?BroadcastExtensionmaybe does more harm than good - needs app groups + team ID, without that we should be able to do Apple'sSAMPLE_CODE_DISAMBIGUATORand "automate" signing for consumersComponents PR: livekit/components-swift#23