Skip to content

user_timestamped_video#8

Merged
stephen-derosa merged 1 commit intomainfrom
sderosa/user_timestamp_video
May 1, 2026
Merged

user_timestamped_video#8
stephen-derosa merged 1 commit intomainfrom
sderosa/user_timestamp_video

Conversation

@stephen-derosa
Copy link
Copy Markdown
Contributor

@stephen-derosa stephen-derosa commented Apr 22, 2026

  • requires a release of client-sdk-cpp to build successfully

Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds a new user_timestamped_video example to the LiveKit C++ example collection, demonstrating end-to-end propagation of VideoFrameMetadata::user_timestamp_us from a synthetic video producer to a consumer that logs received metadata.

Changes:

  • Introduces UserTimestampedVideoProducer to publish synthetic frames with optional user timestamps.
  • Introduces UserTimestampedVideoConsumer to receive camera frames via a rich callback (with metadata) or a legacy callback (without metadata).
  • Wires the new example into the build with CMake and adds usage documentation.

Reviewed changes

Copilot reviewed 7 out of 7 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
user_timestamped_video/producer/main.cpp New producer executable that publishes synthetic BGRA frames and optionally sets metadata.user_timestamp_us.
user_timestamped_video/producer/CMakeLists.txt Builds and links the producer example against the LiveKit core target.
user_timestamped_video/consumer/main.cpp New consumer executable that subscribes to camera frames and logs metadata when enabled.
user_timestamped_video/consumer/CMakeLists.txt Builds and links the consumer example against the LiveKit core target.
user_timestamped_video/README.md Documents how to run producer/consumer and the expected timestamp behavior.
user_timestamped_video/CMakeLists.txt Adds producer/consumer subdirectories for the example.
CMakeLists.txt Adds user_timestamped_video to the top-level build.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread user_timestamped_video/consumer/main.cpp Outdated
Comment thread user_timestamped_video/producer/main.cpp Outdated
Comment thread user_timestamped_video/consumer/main.cpp Outdated
@stephen-derosa stephen-derosa force-pushed the sderosa/user_timestamp_video branch 2 times, most recently from 32a5c90 to bd95181 Compare April 28, 2026 17:14
@stephen-derosa stephen-derosa requested a review from Copilot April 28, 2026 19:01
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 7 out of 7 changed files in this pull request and generated 2 comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread user_timestamped_video/producer/main.cpp Outdated
Comment thread user_timestamped_video/consumer/main.cpp Outdated
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 7 out of 7 changed files in this pull request and generated 3 comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread user_timestamped_video/producer/main.cpp Outdated
Comment thread user_timestamped_video/consumer/main.cpp Outdated
Comment thread user_timestamped_video/README.md
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 7 out of 7 changed files in this pull request and generated 2 comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread user_timestamped_video/consumer/main.cpp Outdated
Comment thread CMakeLists.txt
@stephen-derosa stephen-derosa force-pushed the sderosa/user_timestamp_video branch from 7fcd2ec to a53990a Compare May 1, 2026 17:32
Copy link
Copy Markdown
Contributor

@xianshijing-lk xianshijing-lk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some nits, lgtm in general

Comment thread user_timestamped_video/consumer/main.cpp
Comment thread user_timestamped_video/consumer/main.cpp
Comment thread user_timestamped_video/producer/main.cpp Outdated
@stephen-derosa stephen-derosa force-pushed the sderosa/user_timestamp_video branch from a53990a to 23ff4cc Compare May 1, 2026 19:42
@stephen-derosa stephen-derosa merged commit 6055c28 into main May 1, 2026
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants