Fix: multimodal - audio_samples should never be negative#1651
Open
DaivdYuan wants to merge 1 commit intolivekit:0.xfrom
Open
Fix: multimodal - audio_samples should never be negative#1651DaivdYuan wants to merge 1 commit intolivekit:0.xfrom
DaivdYuan wants to merge 1 commit intolivekit:0.xfrom
Conversation
|
|
|
Member
|
is it happening too for python-agents? |
Author
|
Yes, I got errors in the similar fashion, and after I applied fix in the source code, these errors are gone. |
robin-intbot
added a commit
to intbotinc/livekit-agents
that referenced
this pull request
Apr 14, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix agent_playout.py: audio_samples should be non-negative
See: livekit/agents-js#319
Similar issues: livekit/agents-js#304