Skip to content

Comments

add bey avatar plugin#1700

Closed
niqodea wants to merge 8 commits intolivekit:mainfrom
niqodea:add-bey-plugin
Closed

add bey avatar plugin#1700
niqodea wants to merge 8 commits intolivekit:mainfrom
niqodea:add-bey-plugin

Conversation

@niqodea
Copy link
Contributor

@niqodea niqodea commented Mar 21, 2025

Add the livekit-agents-bey plugin for the Beyond Presence API to handle API calls and local setup for avatar generation.

The API is not live yet, but will be soon. In the meantime, feedback on integration or improvements is welcome!

Note: we reserved the livekit-plugins-bey PyPI package name, let me know if I should add someone from the LiveKit team as owner. 🙏

@changeset-bot
Copy link

changeset-bot bot commented Mar 21, 2025

⚠️ No Changeset found

Latest commit: 8e029ba

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@theomonnom
Copy link
Member

Hey, can you add theomonnom on Pypi

@niqodea
Copy link
Contributor Author

niqodea commented Mar 21, 2025

@theomonnom Done ✅

@niqodea
Copy link
Contributor Author

niqodea commented Mar 24, 2025

@theomonnom would it make sense to include the example from #1669 as well? Without it, using the plugin might not be as straightforward. Maybe we could have it in the README of the plugin?

@longcw
Copy link
Contributor

longcw commented Mar 25, 2025

@niqodea Could you give me a testing api key when the avatar API is live, I'd like to give it a try. Thanks

@theomonnom
Copy link
Member

Hey, I added a force push to v1.0. I did a rebase for you here, feel free to copy the branch #1735

@niqodea niqodea force-pushed the add-bey-plugin branch 2 times, most recently from 791218c to de2e92e Compare March 31, 2025 12:12
license = "Apache-2.0"
requires-python = ">=3.9.0"
authors = [{ name = "LiveKit", email = "support@livekit.io" }]
keywords = ["webrtc", "realtime", "audio", "video", "livekit"]
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we also add avatar here?

@niqodea
Copy link
Contributor Author

niqodea commented Mar 31, 2025

Hi @theomonnom,

Thanks for the rebase! I noticed it just now, and I've already addressed the changes in my branch. Since the commits in your branch are quite similar to mine, I decided to move forward with mine. One difference I noticed is the addition of a new changeset .github/next-release/changeset-c910fa8b.md in your branch. I'm not sure if I should incorporate it into my branch, especially since the CI for it has already passed. If I do need to include it, could you clarify what the hash refers to?

In my rebase, I’ve updated the project metadata to align with the new hatch build system and added better exception handling as a separate commit.

I also noticed the type-check CI step is failing, but the error message suggests it's unrelated to my files. Should I take any action on this?

Looking forward to your feedback and getting this merged. Thanks again for your help!

@github-actions
Copy link
Contributor

github-actions bot commented Mar 31, 2025

❌ Invalid Changeset Format Detected

One or more changeset files in this PR have an invalid format. Please ensure they adhere to:

  • Start with --- and include a closing --- on its own line.
  • Each package line must be in the format:
    "package-name": patch|minor|major
  • No duplicate package entries allowed.
  • A non-empty change description must follow the front matter.

Error details:
.github/next-release/changeset-3cd7dcd2.md: Failed to read file from git branch 'pr_head'.
.github/next-release/changeset-5ca20d29.md: Failed to read file from git branch 'pr_head'.
.github/next-release/changeset-613ef3d7.md: Failed to read file from git branch 'pr_head'.
.github/next-release/changeset-63a12d66.md: Plugin 'livekit-plugins-llama-index' directory does not exist.
.github/next-release/changeset-736911c0.md: Failed to read file from git branch 'pr_head'.
.github/next-release/changeset-9bd9e220.md: Failed to read file from git branch 'pr_head'.
.github/next-release/changeset-f1ea373e.md: Plugin 'livekit-plugins-llama-index' directory does not exist.

@niqodea niqodea force-pushed the add-bey-plugin branch 2 times, most recently from bf455ca to d9e0f40 Compare April 4, 2025 08:00
@niqodea
Copy link
Contributor Author

niqodea commented Apr 4, 2025

Hey @theomonnom, just rebased this on the latest main. I know 1.0 is the focus right now, but would appreciate a quick look when you get a chance. Would be great to get this merged and published alongside the other plugins.

Let me know if anything’s needed on my end!

niqodea and others added 8 commits April 15, 2025 11:10
Co-authored-by: Felix Altenberger <felix@beyondpresence.ai>
Co-authored-by: Lucas Jacobson <lucas@beyondpresence.ai>
Co-authored-by: Nicola De Angeli <nicola@beyondpresence.ai>
@niqodea
Copy link
Contributor Author

niqodea commented Apr 15, 2025

@theomonnom @longcw We'd like to publish this plugin to PyPI ASAP so customers can start integrating it. While this PR is being reviewed, would you be okay with us publishing it manually in the meantime? The copyright and pyproject.toml already list LiveKit as the author—just want to confirm you're good with it before proceeding. Thanks!

@longcw
Copy link
Contributor

longcw commented Apr 24, 2025

#2031

@longcw longcw closed this Apr 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants