add input_mode to SpeechHandle #4701
Open
+59
−12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
chenghao-mou
approved these changes
Feb 3, 2026
Member
chenghao-mou
left a comment
chenghao-mou
left a comment
There was a problem hiding this comment.
lgtm, two minor nitpicking comments.
| @@ -82,7 +82,7 @@ async def on_enter(self) -> None: | |||
| self.session.generate_reply(instructions="Ask the user to provide an email address.") | |||
Member
There was a problem hiding this comment.
Do we want to update the other task in address.py as well?
Contributor
Author
There was a problem hiding this comment.
yeah I'll update other tasks once it's settled
davidzhao
reviewed
Feb 4, 2026
Member
davidzhao
left a comment
davidzhao
left a comment
There was a problem hiding this comment.
in room_io chat handler, we should set input_mode to text right?
Contributor
Author
yes, it's using |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.