Skip to content

ensure proc pool spawns processes for waiting jobs under high load#4820

Merged
theomonnom merged 2 commits intomainfrom
theo/fix-stuck
Feb 15, 2026
Merged

ensure proc pool spawns processes for waiting jobs under high load#4820
theomonnom merged 2 commits intomainfrom
theo/fix-stuck

Conversation

@theomonnom
Copy link
Member

No description provided.

@chenghao-mou chenghao-mou requested a review from a team February 14, 2026 23:09
Copy link
Contributor

@devin-ai-integration devin-ai-integration bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Devin Review: No Issues Found

Devin Review analyzed this PR and found no potential bugs to report.

View in Devin Review to see 3 additional findings.

Open in Devin Review

min(self._target_idle_processes, self._default_num_idle_processes),
self._jobs_waiting_for_process,
)
to_spawn = target - current_pending
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could this be negative? then would range throw?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You will get an empty iterator

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

>>> print(list(range(-20)))
[]

@theomonnom theomonnom requested a review from davidzhao February 15, 2026 01:56
@theomonnom theomonnom merged commit 02e49a7 into main Feb 15, 2026
16 of 18 checks passed
@theomonnom theomonnom deleted the theo/fix-stuck branch February 15, 2026 02:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants