Skip to content

skip adding run event when run result is done #4925

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
longcw merged 2 commits into from
Feb 24, 2026
Merged

skip adding run event when run result is done #4925

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
39b2423
skip adding run event when run result is done
longcw Feb 23, 2026
b28d535
fix final_output
longcw Feb 23, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion livekit-agents/livekit/agents/voice/run_result.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -135,6 +135,9 @@ async def _await_impl() -> RunResult[Run_T]:
def _agent_handoff(
self, *, item: llm.AgentHandoff, old_agent: Agent | None, new_agent: Agent
) -> None:
if self._done_fut.done():
return

event = AgentHandoffEvent(item=item, old_agent=old_agent, new_agent=new_agent)
index = self._find_insertion_index(created_at=event.item.created_at)
self._recorded_items.insert(index, event)
Expand All @@ -156,6 +159,9 @@ def _item_added(self, item: llm.ChatItem) -> None:
self._recorded_items.insert(index, event)

def _watch_handle(self, handle: SpeechHandle | asyncio.Task) -> None:
if self._done_fut.done():
return

self._handles.add(handle)

if isinstance(handle, SpeechHandle):
Expand Down Expand Up @@ -189,7 +195,7 @@ def _mark_done(self) -> None:
self._done_fut.set_exception(
RuntimeError(
f"Expected output of type {self._output_type.__name__}, "
f"got {type(self._final_output).__name__}"
f"got {type(final_output).__name__}"
)
)
else:
Expand Down
Loading