Skip to content

add livekit-blockguard plugin#5023

Merged
theomonnom merged 5 commits intomainfrom
theo/blockguard
Mar 19, 2026
Merged

add livekit-blockguard plugin#5023
theomonnom merged 5 commits intomainfrom
theo/blockguard

Conversation

@theomonnom
Copy link
Member

No description provided.

@chenghao-mou chenghao-mou requested a review from a team March 6, 2026 05:01
devin-ai-integration[bot]

This comment was marked as resolved.

devin-ai-integration[bot]

This comment was marked as resolved.

devin-ai-integration[bot]

This comment was marked as resolved.

devin-ai-integration[bot]

This comment was marked as resolved.

theomonnom and others added 3 commits March 5, 2026 22:03
Keep the blockguard plugin standalone without modifying the core agents package,
so the plugin can be merged independently.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@theomonnom theomonnom merged commit a358e38 into main Mar 19, 2026
18 of 21 checks passed
@theomonnom theomonnom deleted the theo/blockguard branch March 19, 2026 03:30
Copy link
Contributor

@devin-ai-integration devin-ai-integration bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Devin Review found 1 new potential issue.

View 19 additional findings in Devin Review.

Open in Devin Review

Comment on lines +5 to +7
[tool.cibuildwheel]
skip = "*-musllinux_*"
test-command = "python {project}/test_import.py"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Missing cibuildwheel build directive causes wheels to not be built for all supported Python versions

The livekit-blockguard/pyproject.toml is missing the build directive under [tool.cibuildwheel]. The sibling plugin livekit-durable (livekit-plugins/livekit-durable/pyproject.toml:9) explicitly specifies build = "cp310-* cp311-* cp312-* cp313-* cp314-*" to ensure wheels are built for all supported Python versions. Without this directive, cibuildwheel falls back to its built-in defaults, which may not include Python 3.13 and 3.14 — even though setup.py:52 declares python_requires=">=3.10.0,<3.15" and the classifiers list Python 3.13 and 3.14. This would result in missing wheel artifacts for those Python versions during release.

Suggested change
[tool.cibuildwheel]
skip = "*-musllinux_*"
test-command = "python {project}/test_import.py"
[tool.cibuildwheel]
build = "cp310-* cp311-* cp312-* cp313-* cp314-*"
skip = "*-musllinux_*"
test-command = "python {project}/test_import.py"
Open in Devin Review

Was this helpful? React with 👍 or 👎 to provide feedback.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant