Skip to content

openai: add max_completion_tokens to with_azure()#5143

Merged
davidzhao merged 1 commit intolivekit:mainfrom
abhishekranjan-bluemachines:feat/azure-with-azure-max-completion-tokens
Mar 19, 2026
Merged

openai: add max_completion_tokens to with_azure()#5143
davidzhao merged 1 commit intolivekit:mainfrom
abhishekranjan-bluemachines:feat/azure-with-azure-max-completion-tokens

Conversation

@abhishekranjan-bluemachines
Copy link
Contributor

Summary

  • Add max_completion_tokens parameter to LLM.with_azure() static method, forwarding it to the LLM constructor
  • This parameter was already supported by LLM.__init__ and sent correctly to the Azure OpenAI API, but with_azure() didn't expose it

Test plan

  • Verify max_completion_tokens is passed through with_azure()LLM.__init__self._optschat.completions.create()
  • Confirm Azure OpenAI API accepts max_completion_tokens (supported since api-version 2024-08-01-preview)

🤖 Generated with Claude Code

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Copy link
Contributor

@devin-ai-integration devin-ai-integration bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Devin Review: No Issues Found

Devin Review analyzed this PR and found no potential bugs to report.

View in Devin Review to see 1 additional finding.

Open in Devin Review

@davidzhao davidzhao merged commit e613b64 into livekit:main Mar 19, 2026
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants