Skip to content

Fix/stt fallback adapter propagate aligned transcript#5237

Merged
davidzhao merged 2 commits intolivekit:mainfrom
miladmnasr:fix/stt-fallback-adapter-propagate-aligned-transcript
Mar 27, 2026
Merged

Fix/stt fallback adapter propagate aligned transcript#5237
davidzhao merged 2 commits intolivekit:mainfrom
miladmnasr:fix/stt-fallback-adapter-propagate-aligned-transcript

Conversation

@miladmnasr
Copy link
Copy Markdown
Contributor

@miladmnasr miladmnasr commented Mar 26, 2026

Summary

stt.FallbackAdapter hardcodes aligned_transcript=False in its STTCapabilities,
even when all underlying STT providers support it. This silently disables adaptive
interruption handling, which checks stt.capabilities.aligned_transcript in
_resolve_interruption_detection().

This fix derives aligned_transcript from the child STTs — if all support it,
use the primary provider's value; otherwise False.

Fixes #5236

FallbackAdapter hardcodes aligned_transcript=False in STTCapabilities,
even when all underlying STT providers support it. This silently
disables adaptive interruption handling, which requires aligned
transcripts.
@CLAassistant
Copy link
Copy Markdown

CLAassistant commented Mar 26, 2026

CLA assistant check
All committers have signed the CLA.

Copy link
Copy Markdown
Contributor

@devin-ai-integration devin-ai-integration bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Devin Review: No Issues Found

Devin Review analyzed this PR and found no potential bugs to report.

View in Devin Review to see 2 additional findings.

Open in Devin Review

@davidzhao davidzhao merged commit 2503f6f into livekit:main Mar 27, 2026
14 checks passed
osimhi213 added a commit to de-id/livekit-agents that referenced this pull request Mar 29, 2026
…endor

* upstream/main:
  Baseten Plugin Update: fix metadata schema, add chain_id support, and improve response parsing (livekit#4889)
  feat(anthropic): support strict tool use schema (livekit#5259)
  feat(mistral): add voxtral TTS support (livekit#5245)
  Fix/stt fallback adapter propagate aligned transcript (livekit#5237)
  fix: expose endpointing_opts in AgentSession.update_options() (livekit#5243)
  fix(utils): improve type annotation for deprecate_params decorator (livekit#5244)
  (google realtime): add gemini-3.1-flash-live-preview model (livekit#5233)
  fix: Nova Sonic interactive context bugs and dynamic tool support (livekit#5220)
  feat(assemblyai): add domain parameter for Medical Mode (livekit#5208)
  fix: ensure MCP client enter/exit run in the same task (livekit#5223)
  feat(google): add VertexRAGRetrieval provider tool (livekit#5222)
osimhi213 added a commit to de-id/livekit-agents that referenced this pull request Mar 29, 2026
* upstream/main:
  Baseten Plugin Update: fix metadata schema, add chain_id support, and improve response parsing (livekit#4889)
  feat(anthropic): support strict tool use schema (livekit#5259)
  feat(mistral): add voxtral TTS support (livekit#5245)
  Fix/stt fallback adapter propagate aligned transcript (livekit#5237)
  fix: expose endpointing_opts in AgentSession.update_options() (livekit#5243)
  fix(utils): improve type annotation for deprecate_params decorator (livekit#5244)
  (google realtime): add gemini-3.1-flash-live-preview model (livekit#5233)
  fix: Nova Sonic interactive context bugs and dynamic tool support (livekit#5220)
  feat(assemblyai): add domain parameter for Medical Mode (livekit#5208)
  fix: ensure MCP client enter/exit run in the same task (livekit#5223)
  feat(google): add VertexRAGRetrieval provider tool (livekit#5222)
osimhi213 added a commit to de-id/livekit-agents that referenced this pull request Mar 29, 2026
* feat(google): add VertexRAGRetrieval provider tool (livekit#5222)

* fix: ensure MCP client enter/exit run in the same task (livekit#5223)

* feat(assemblyai): add domain parameter for Medical Mode (livekit#5208)

* fix: Nova Sonic interactive context bugs and dynamic tool support (livekit#5220)

Co-authored-by: Pavas Kant <pavkan@amazon.com>

* (google realtime): add gemini-3.1-flash-live-preview model (livekit#5233)

* fix(utils): improve type annotation for deprecate_params decorator (livekit#5244)

* fix: expose endpointing_opts in AgentSession.update_options() (livekit#5243)

* Fix/stt fallback adapter propagate aligned transcript (livekit#5237)

* feat(mistral): add voxtral TTS support (livekit#5245)

* feat(anthropic): support strict tool use schema (livekit#5259)

* Baseten Plugin Update: fix metadata schema, add chain_id support, and improve response parsing (livekit#4889)

---------

Co-authored-by: Yousuf Bukhari <25112850+youpesh@users.noreply.github.com>
Co-authored-by: Long Chen <longch1024@gmail.com>
Co-authored-by: Martin Schweiger <34636718+m-ods@users.noreply.github.com>
Co-authored-by: Osman-AGI <uyguripek@gmail.com>
Co-authored-by: Pavas Kant <pavkan@amazon.com>
Co-authored-by: Tina Nguyen <72938484+tinalenguyen@users.noreply.github.com>
Co-authored-by: Milad <129620931+miladmnasr@users.noreply.github.com>
Co-authored-by: Jean Perbet <jeanperbet@icloud.com>
Co-authored-by: Shaik Faizan Roshan Ali <roshan.shaik.ml@gmail.com>
Co-authored-by: jiegong-fde <jie.gong@baseten.co>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

STT FallbackAdapter drops aligned_transcript capability, silently disabling adaptive interruption

3 participants