Ojin Plugin#5295
Conversation
|
|
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
|
Hi @tinalenguyen, when you have a chance, could you review this Ojin avatar plugin PR? I updated it against the latest |
|
hi @php-workx, thanks for the contribution! it seems that there are merge conflicts at the moment, i also don't believe we will be including avatar plugins in our test suite quite yet also is the edit in |
…ffer management and implement session-ready timeout
…r.py` for clarity
…jin/agent_worker`
Align AvatarSession with ecosystem convention used by anam and lemonslice plugins. Replaces `reconnect_attempts` and `reconnect_delay` params with `conn_options: APIConnectOptions = DEFAULT_API_CONNECT_OPTIONS`, adding connect timeout support via asyncio.wait_for on the initial WS connection.
Moves test files from the root tests/ directory into livekit-plugins/livekit-plugins-ojin/tests/, consistent with how other plugins (aws, hamming) structure their tests.
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
|
@tinalenguyen / thanks for your comments!
We have moved to plugin tests in the plugin folder.
Reverted, but worth noting: it seems like Devin has flag this as well: #5295 (comment) |
Without this, the OjinClient WebSocket connection and AvatarRunner are never closed when the job shuts down. Mirrors the pattern from the base AvatarSession in _types.py, applied manually since our local-runner architecture doesn't support full inheritance (no avatar participant, no avatar_identity, _wait_avatar_join not applicable).
3 participants
livekit-plugins-ojin)Ojin Documentation
Ojin Model API