fix: clear _hist buffer in MovingAverage.reset() to prevent stale averages#5522
Merged
longcw merged 1 commit intolivekit:mainfrom Apr 22, 2026
Merged
Conversation
…ues (Closes livekit#5521) Signed-off-by: Cocoon-Break <54054995+kuishou68@users.noreply.github.com>
|
|
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
longcw
reviewed
Apr 22, 2026
| return self._sum / self.size() | ||
|
|
||
| def reset(self) -> None: | ||
| self._hist = [0.0] * len(self._hist) |
Contributor
There was a problem hiding this comment.
the hist is used only when count > len(hist), that means all values in hist were overwritten already. but I think it's good to also reset it here.
longcw
approved these changes
Apr 22, 2026
Contributor
|
could you sign the CLA so we can merge it? |
Contributor
Author
OK |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #5521
Problem
MovingAverage.reset()resets_countand_sumto zero but does not clear the_histring-buffer. After a reset, once the window fills again, the eviction path subtracts stale pre-reset values from_sum, producing incorrect moving averages.Fix
Clear
_histinreset()by replacing with a zero-initialized list of the same length.Changes
livekit-agents/livekit/agents/utils/moving_average.py: addedself._hist = [0.0] * len(self._hist)as first line ofreset()