Skip to content

(liveavatar): add video_quality param#5552

Merged
tinalenguyen merged 2 commits intomainfrom
tina/liveavatar-video-quality
Apr 24, 2026
Merged

(liveavatar): add video_quality param#5552
tinalenguyen merged 2 commits intomainfrom
tina/liveavatar-video-quality

Conversation

@tinalenguyen
Copy link
Copy Markdown
Member

claude, please port this plugin and PR 🙏

@chenghao-mou chenghao-mou requested a review from a team April 24, 2026 21:23
Copy link
Copy Markdown
Contributor

@devin-ai-integration devin-ai-integration Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Devin Review: No Issues Found

Devin Review analyzed this PR and found no potential bugs to report.

View in Devin Review to see 1 additional finding.

Open in Devin Review

room: rtc.Room,
avatar_id: str,
is_sandbox: bool = False,
video_quality: str | None = None,
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we also use the Literal here? For better typing?

Copy link
Copy Markdown
Member

@theomonnom theomonnom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@tinalenguyen tinalenguyen merged commit d00b0c7 into main Apr 24, 2026
23 checks passed
@tinalenguyen tinalenguyen deleted the tina/liveavatar-video-quality branch April 24, 2026 21:45
Copy link
Copy Markdown
Contributor

This is an automated Claude Code Routine created by @toubatbrian. Right now it is in experimentation stage.

Skipping port to agents-js.

The liveavatar plugin does not currently exist in livekit/agents-js. It was explicitly listed as a Python-only plugin (no JS counterpart) in the prior automated port at livekit/agents-js#1280, alongside avatario, avatartalk, bithuman, did, keyframe, simli, and tavus.

This PR is a narrow additive diff (~17 lines) against avatar.py / api.py that adds a video_quality parameter. Porting just the diff isn't possible because the base plugin doesn't exist in JS, and spinning up a full JS port of liveavatar from a single parameter-addition PR is out of scope for this routine — it would require porting ~500 lines of plugin code plus primitives the JS runtime may not yet expose (QueueAudioOutput, AudioSegmentEnd, rtc.AudioResampler, on-the-wire websocket protocol, etc.).

If the intent is to stand up a brand-new @livekit/agents-plugin-liveavatar package in agents-js, that's best tracked as its own dedicated task (happy to pick it up if filed as a separate request to this routine). For now, flagging this port as intentionally skipped so it doesn't silently fall through.

cc @toubatbrian @livekit/agent-devs


Generated by Claude Code

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants