Skip to content

Update codec config, MIME mapping, and interruption handling#5561

Merged
tinalenguyen merged 8 commits into
livekit:mainfrom
dhruvladia-sarvam:fix/tts-plugin-updates
May 12, 2026
Merged

Update codec config, MIME mapping, and interruption handling#5561
tinalenguyen merged 8 commits into
livekit:mainfrom
dhruvladia-sarvam:fix/tts-plugin-updates

Conversation

@dhruvladia-sarvam
Copy link
Copy Markdown
Contributor

  • Always send output_audio_codec in WebSocket config (was only in
    model-specific branches, silently omitted for unmatched models)
  • Add _codec_to_mime_type() mapping so linear16/mulaw/alaw correctly
    resolve to audio/pcm instead of invalid MIME types
  • Expand ALLOWED_OUTPUT_AUDIO_CODECS to include linear16, mulaw, alaw
  • Guard send_task and recv_task against ConnectionResetError during
    barge-in so transport-closing errors are suppressed, not re-raised
  • Add input_sent_event coordination between send/recv tasks to prevent
    recv from starting before config is sent
  • Simplify aclose() to delegate to base class, avoiding race with
    ConnectionPool cleanup

devin-ai-integration[bot]

This comment was marked as resolved.

@tinalenguyen
Copy link
Copy Markdown
Member

hi, thanks for the PR! i tried it and got this log: TTS API error: Input parameters has to be a valid dictionary

@dhruvladia-sarvam
Copy link
Copy Markdown
Contributor Author

i tried it and got this log: TTS API error: Input parameters has to be a valid dictionary

You must've received it for bulbul:v2, right?

@tinalenguyen
Copy link
Copy Markdown
Member

Yes, the default model

@dhruvladia-sarvam
Copy link
Copy Markdown
Contributor Author

@tinalenguyen please re-review

devin-ai-integration[bot]

This comment was marked as resolved.

@dhruvladia-sarvam
Copy link
Copy Markdown
Contributor Author

@tinalenguyen requesting a re-review

devin-ai-integration[bot]

This comment was marked as resolved.

@tinalenguyen
Copy link
Copy Markdown
Member

hi @dhruvladia-sarvam, i still hit the same error when trying it out

Copy link
Copy Markdown
Member

@tinalenguyen tinalenguyen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks!!

@tinalenguyen tinalenguyen merged commit 59abab4 into livekit:main May 12, 2026
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants