fix(amd): amd improvement (AGT-2777)#5584
Conversation
1. expose all turnable parameters; 2. use llm when transcript is available; 3. increase timeout values closes #5477
chenghao-mou
changed the title
- SIP example with RPC - support separate STT for realtime agents
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
| for participant in room.remote_participants.values(): | ||
| for pub in participant.track_publications.values(): | ||
| if ( | ||
| pub.subscribed | ||
| and pub.track is not None | ||
| and pub.track.kind == rtc.TrackKind.KIND_AUDIO | ||
| ): | ||
| if ( | ||
| self._participant_identity is None | ||
| or participant.identity == self._participant_identity | ||
| ): | ||
| self._on_track_subscribed( | ||
| pub.track, | ||
| pub, | ||
| participant, | ||
| ) | ||
| break |
There was a problem hiding this comment.
I think we have an utility somewhere for that
There was a problem hiding this comment.
There was a problem hiding this comment.
one small thing about that function is that publication -> subscription might have a gap. I will add one option to that function to wait for subscription.
|
|
||
| model = model.lower() | ||
| if all( | ||
| model != candidate.lower() and model not in candidate.lower() |
There was a problem hiding this comment.
🟡 Reversed substring check in _warn_if_not_evaluated causes incorrect warning suppression/triggering
model not in candidate.lower() checks whether the user's model string is a substring of the evaluated candidate, but the intended behavior is the reverse: whether the evaluated candidate is a substring of the user's model. This means versioned model strings like "deepgram/nova-3-medical" will incorrectly trigger a warning (because it's not a substring of "deepgram/nova-3"), while short partial strings like "nova" will incorrectly suppress the warning (because "nova" IS a substring of "deepgram/nova-3").
| model != candidate.lower() and model not in candidate.lower() | |
| model != candidate.lower() and candidate.lower() not in model |
Was this helpful? React with 👍 or 👎 to provide feedback.
|
This is an automated Claude Code Routine created by @toubatbrian. Right now it is in experimentation stage. The automation will start porting this PR into agents-js automatically. This PR is classified as a core runtime improvement (changes to A draft PR will be opened on Generated by Claude Code |
4 participants
closes #5477