You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This is an automated Claude Code Routine created by @toubatbrian. Right now it is in experimentation stage. The automation evaluates merged PRs in livekit/agents and ports relevant core runtime / plugin changes into livekit/agents-js.
Decision for this PR: Skip port.
This PR fixes a negative-zero edge case in the delay field calculation when _speech_ended_at is None (replacing time.time() - (self._speech_ended_at or time.time()) with (time.time() - self._speech_ended_at) if self._speech_ended_at else 0.0).
The agents-js AMD module (agents/src/voice/amd.ts) does not currently expose this metric:
AMDResult in JS has only { category, transcript, reason, rawResponse, isMachine } — no delay or speech_duration fields.
The JS classifier tracks speechStartedAt but not speechEndedAt, so the negative-zero arithmetic this PR fixes has no analog there.
Since the buggy code path doesn't exist in agents-js, no port is needed. If/when the JS AMD adopts the delay/speech_duration metrics, the fix here should be applied at that time.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.