fix: pass API key via header in Neuphonic and Murf WebSocket TTS#5691
Merged
fix: pass API key via header in Neuphonic and Murf WebSocket TTS#5691
Conversation
The X-API-KEY header was already being set on the WS handshake, so the api_key query param was redundant. Removing it avoids URL-encoding fragility and keeps the key out of any proxy/access logs. JWT-token URL handling is unchanged.
Murf's official Python SDK uses the api-key HTTP header for REST, and the WebSocket API reference lists api-key as a supported header. Move the credential out of the URL to avoid URL-encoding fragility and to keep it out of proxy/access logs.
theomonnom
approved these changes
May 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Both
livekit-plugins-neuphonicandlivekit-plugins-murfwere embedding the API key in the WebSocket URL query string without URL-encoding. Move the key onto the WS handshake header instead — both providers' SDKs/docs already support header auth.Changes
api_key=from the WS URL; the existingX-API-KEYheader was already redundantly set on the handshake. JWT-token URL handling is unchanged.?api-key=...query param to theapi-keyheader (matches Murf's official Python SDK and WS API reference).Testing
make check(ruff lint + format-check) passes locally on both edited files.