fix(voice): race between flush and clear_buffer on interrupt leaks unplayed transcript#5798
Merged
Merged
Conversation
When a speech was interrupted right around playout, the entire reply text could leak into the chat context. The cancelled `_audio_forwarding_task` called `flush()` in its finally block, which let the tiny in-flight audio drain naturally and report `interrupted=False` before agent_activity's `clear_buffer()` could mark it interrupted. The synchronizer then treated playback as completed and returned the full pushed text as the synchronized transcript. Call `clear_buffer()` from the cancelled task's finally so the interruption signal lands before any natural completion event fires. Also read `_interrupted_event` directly in `_ParticipantAudioOutput` so the interrupted flag isn't lost when both wait futures complete in the same loop tick.
longcw
changed the title
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
chenghao-mou
approved these changes
May 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
_audio_forwarding_taskcalledflush()in its finally block, which let the tiny in-flight audio drain naturally and reportinterrupted=Falsebeforeagent_activity'sclear_buffer()could mark it interrupted. The synchronizer then treated playback as completed and returned the full pushed text as the synchronized transcript.clear_buffer()from the cancelled task's finally so the interrupt signal lands before any natural completion event fires.