fix: 4xx errors should not be retryable#5831
Merged
Merged
Conversation
there are two knobs to control if a request is retryable: 1. has it produced a response already (if so, retrying it produces unpredictable output) 2. what type of error is it? 4xx means client made a mistake, which generally cannot be retried currently we are assuming a single `retryable` flag is setting both, where it actually only reflects 1. this fix addresses 2 in a central manner, so the retryable flag is only used for 1.
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
theomonnom
approved these changes
May 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
there are two knobs to control if a request is retryable:
currently we are assuming a single
retryableflag is setting both, where it actually only reflects 1. this fix addresses 2 in a central manner, so the retryable flag is only used for 1.